From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] regulator: mc13783: Add device tree probe support
Date: Sun, 7 Apr 2013 20:21:58 +0100 [thread overview]
Message-ID: <20130407192157.GQ6597@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1365354131-9770-1-git-send-email-shc_work@mail.ru>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Sun, Apr 07, 2013 at 09:02:11PM +0400, Alexander Shiyan wrote:
> Patch adds device tree probe support for mc13783-regulator driver.
I'd expect to see a document describing the binding for any new binding.
> + if (num_parsed != num_regulators) {
> + dev_warn(&pdev->dev,
> + "parsed %d != regulators %d - check your device tree!\n",
> + num_parsed, num_regulators);
>
> - init_data = &pdata->regulators[i];
> - desc = &mc13783_regulators[init_data->id].desc;
> + num_regulators = num_parsed;
> + priv->num_regulators = num_regulators;
Why is this something we warn about? Users should be able to omit
unused regulators, no point in adding nodes that don't have any real
information.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-07 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 17:02 Alexander Shiyan
2013-04-07 19:21 ` Mark Brown [this message]
2013-04-08 16:46 ` Re[2]: " Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130407192157.GQ6597@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome