From: Samuel Ortiz <sameo@linux.intel.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Mark Brown'" <broonie@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: wm8994: silence bogus warning in wm8994_device_init()
Date: Mon, 8 Apr 2013 11:57:54 +0200 [thread overview]
Message-ID: <20130408095754.GQ24058@zurbaran> (raw)
In-Reply-To: <007101ce0f15$7a726410$6f572c30$%han@samsung.com>
Hi Jingoo,
On Wed, Feb 20, 2013 at 11:53:36AM +0900, Jingoo Han wrote:
> 'patch_regs' cannot be used uninitialized in wm8994_device_init(),
> because 'patch_regs' was already guarded by 'regmap_patch'.
> Thus, that's a bogus warning.
>
> Without this patch, the build warning happens as below:
>
> drivers/mfd/wm8994-core.c: In function 'wm8994_i2c_probe':
> drivers/mfd/wm8994-core.c:595:7: warning: 'patch_regs' may be used uninitialized in this function [-Wuninitialized]
> drivers/mfd/wm8994-core.c:408:14: note: 'patch_regs' was declared here
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/wm8994-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-04-08 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 0:56 [PATCH] mfd: wm8994: add missing variable initialization Jingoo Han
2013-02-19 12:18 ` Mark Brown
2013-02-20 2:53 ` [PATCH v2] mfd: wm8994: silence bogus warning in wm8994_device_init() Jingoo Han
2013-02-20 16:48 ` Mark Brown
2013-04-08 9:57 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408095754.GQ24058@zurbaran \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®