From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Guenter Roeck <linux@roeck-us.net>,
Al Viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Convert compat_sys_sysinfo to COMPAT_SYSCALL_DEFINE
Date: Mon, 8 Apr 2013 14:35:54 -0700 [thread overview]
Message-ID: <20130408143554.3d23a6d96bd880d46c201e8a@linux-foundation.org> (raw)
In-Reply-To: <20130408145616.fc074f04c4c813fd2eac96a1@canb.auug.org.au>
On Mon, 8 Apr 2013 14:56:16 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> --- a/kernel/timer.c
> +++ b/kernel/timer.c
> @@ -1661,8 +1661,7 @@ struct compat_sysinfo {
> char _f[20-2*sizeof(u32)-sizeof(int)];
> };
>
> -asmlinkage long
> -compat_sys_sysinfo(struct compat_sysinfo __user *info)
> +COMPAT_SYSCALL_DEFINE1(sysinfo, struct compat_sysinfo __user *, info)
wtflol.
akpm3:/usr/src/25> grep SYSCALL kernel/timer.c
SYSCALL_DEFINE1(alarm, unsigned int, seconds)
SYSCALL_DEFINE0(getpid)
SYSCALL_DEFINE0(getppid)
SYSCALL_DEFINE0(getuid)
SYSCALL_DEFINE0(geteuid)
SYSCALL_DEFINE0(getgid)
SYSCALL_DEFINE0(getegid)
SYSCALL_DEFINE0(gettid)
SYSCALL_DEFINE1(sysinfo, struct sysinfo __user *, info)
COMPAT_SYSCALL_DEFINE1(sysinfo, struct compat_sysinfo __user *, info)
Only one of those should be in kernel/timer.c. Who wrote this thing?
next prev parent reply other threads:[~2013-04-08 21:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 1:53 [PATCH] Make do_sysinfo() static Stephen Rothwell
2013-04-08 2:00 ` Al Viro
2013-04-08 3:04 ` Stephen Rothwell
2013-04-08 4:43 ` [PATCH v2] " Stephen Rothwell
2013-04-08 4:56 ` [PATCH] Convert compat_sys_sysinfo to COMPAT_SYSCALL_DEFINE Stephen Rothwell
2013-04-08 21:35 ` Andrew Morton [this message]
2013-04-09 8:26 ` [PATCH] Clean up kernel/timer.c Stephen Rothwell
2013-04-09 9:06 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408143554.3d23a6d96bd880d46c201e8a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®