From: Samuel Ortiz <sameo@linux.intel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: drop "select PMIC_DA9055"
Date: Tue, 9 Apr 2013 09:10:35 +0200 [thread overview]
Message-ID: <20130409071035.GE24058@zurbaran> (raw)
In-Reply-To: <1362846754.3137.9.camel@x61.thuisdomein>
Hi Paul,
On Sat, Mar 09, 2013 at 05:32:34PM +0100, Paul Bolle wrote:
> The Kconfig entry for DA9055 PMIC Support selects PMIC_DA9055. That was
> probably inspired by the similar select statement in the entry for
> DA9052/53 PMIC with I2C. But the DA9055 PMIC only comes in an I2C
> variant and its driver doesn't need a separate Kconfig symbol for shared
> code. In any case, this select can be dropped as PMIC_DA9055 doesn't
> exist.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested with "git grep" only.
>
> 1) Note that the DA9052 and DA9055 drivers all have code for module
> support, but their Kconfig entries only allow them to be builtin. Can't
> these entries be made tristate? If not, shouldn't the code for module
> support be removed?
>
> drivers/mfd/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Patch applied to mfd-next, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-04-09 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 16:32 Paul Bolle
2013-04-09 7:10 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409071035.GE24058@zurbaran \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®