mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Clements <paul.clements@steeleye.com>
Cc: <linux-kernel@vger.kernel.org>, <belczyk@bsd.krakow.pl>
Subject: Re: [PATCH] nbd: increase default and max request sizes
Date: Thu, 11 Apr 2013 15:34:02 -0700	[thread overview]
Message-ID: <20130411153402.12cfa2ad0c4501be1331e748@linux-foundation.org> (raw)
In-Reply-To: <20130402194120.54043222C0@clements>

On Tue,  2 Apr 2013 15:41:20 -0400 (EDT) Paul Clements <paul.clements@steeleye.com> wrote:

> This patch raises the default max request size for nbd to 128KB (from 127KB)
> to get it 4KB aligned. This patch also allows the max request size to be
> increased (via /sys/block/nbd<x>/queue/max_sectors_kb) to 32MB.
> 
> The patch makes nbd network traffic more efficient by:
> - reducing request fragmentation (4KB alignment)
> - reducing the number of requests (fewer round trips, less network overhead)
> 
> Especially in high latency networks, larger request size can make a dramatic
> difference in performance.
> 
> From: Michal Belczyk <belczyk@bsd.krakow.pl>
> Signed-off-by: Paul Clements <paul.clements@steeleye.com>

This is a bit odd.

- The author's "From:" line shouild appear right at the start of the
  changelog.

- Michal's Signed-off-by: is absent.  Is one available?

Thanks.

      reply	other threads:[~2013-04-11 22:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 19:41 Paul Clements
2013-04-11 22:34 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130411153402.12cfa2ad0c4501be1331e748@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=belczyk@bsd.krakow.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.clements@steeleye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®