From: Frederic Weisbecker <fweisbec@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Christoph Lameter <cl@linux.com>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Metcalf <cmetcalf@tilera.com>,
Geoff Levand <geoff@infradead.org>,
Gilad Ben Yossef <gilad@benyossef.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Kevin Hilman <khilman@linaro.org>,
Li Zhong <zhong@linux.vnet.ibm.com>,
Namhyung Kim <namhyung.kim@lge.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 4/4] nohz: New option to force all CPUs in full dynticks range
Date: Thu, 11 Apr 2013 19:28:05 +0200 [thread overview]
Message-ID: <20130411172803.GC17129@somewhere.redhat.com> (raw)
In-Reply-To: <20130411171153.GG29861@linux.vnet.ibm.com>
On Thu, Apr 11, 2013 at 10:11:53AM -0700, Paul E. McKenney wrote:
> On Thu, Apr 11, 2013 at 07:04:23PM +0200, Frederic Weisbecker wrote:
> > On Thu, Apr 11, 2013 at 04:41:07PM +0000, Christoph Lameter wrote:
> > > On Thu, 11 Apr 2013, Frederic Weisbecker wrote:
> > >
> > > > If there is no performance issue with that I'm all for it.
> > >
> > > Or have a
> > >
> > > CONFIG_LOWLATENCY
> > >
> > > that boots up a kernel with the proper configuration?
> >
> > It may be too general for a naming. But I don't mind just
> > selecting CONFIG_RCU_NOCBS_ALL unconditionally. It's easily
> > changed in the future if anybody complains.
> >
> > Btw, if CONFIG_RCU_NOCBS_ALL is set, the rcu_nocbs= parameter
> > is ignored, right? If you want to keep that direction and not
> > override the Kconfig choice, may be warn the user about that
> > if the boot parameter is passed?
>
> Fair point. Let me think about how I should approach Thanx.
An alternative is to treat the Kconfig choice as a default setting
that gets overriden by rcu_nocbs=
This would require to refactor the three way Kconfig layout you've set,
but that aligns with what Ingo is suggesting me to do with the full dynticks
range: having CONFIG_NO_HZ_EXTENDED_ALL that is overriden by nohz_extended=
if any (beware though, "extended" will soon be renamed to "full", lets hope
it's our last take ;)
That unifies both behaviours and it looks more flexible to me.
Of course that means selecting CONFIG_RCU_NOCBS_ALL won't be enough for
me to ensure my nohz range is also nocb, I'm fine with the cpumask check
on boot though.
Anyway, that's just a suggestion, the most important is that the
user is informed of what's happening and how to deal with it.
next prev parent reply other threads:[~2013-04-11 17:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 15:32 [PATCH 0/4] nohz: Full dynticks fixes/improvements Frederic Weisbecker
2013-03-27 15:32 ` [PATCH 1/4] nohz: Force boot CPU outside full dynticks range Frederic Weisbecker
2013-03-28 7:38 ` Ingo Molnar
2013-03-28 13:08 ` Frederic Weisbecker
2013-03-27 15:32 ` [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot Frederic Weisbecker
2013-03-28 7:40 ` Ingo Molnar
2013-03-28 13:12 ` Frederic Weisbecker
2013-03-29 0:25 ` Paul Gortmaker
2013-03-29 0:39 ` Frederic Weisbecker
2013-03-29 2:00 ` Paul E. McKenney
2013-03-29 2:08 ` Paul Gortmaker
2013-03-29 3:51 ` Paul E. McKenney
2013-03-29 2:02 ` Paul Gortmaker
2013-03-27 15:32 ` [PATCH 3/4] nohz: Ensure full dynticks CPUs are RCU nocbs Frederic Weisbecker
2013-03-27 15:32 ` [PATCH 4/4] nohz: New option to force all CPUs in full dynticks range Frederic Weisbecker
2013-03-28 7:45 ` Ingo Molnar
2013-03-28 13:43 ` Frederic Weisbecker
2013-03-30 9:10 ` Ingo Molnar
2013-04-02 13:09 ` Frederic Weisbecker
2013-04-08 14:57 ` Christoph Lameter
2013-04-09 13:22 ` Paul Gortmaker
2013-04-09 14:35 ` Christoph Lameter
2013-04-11 15:19 ` Frederic Weisbecker
2013-04-11 15:37 ` Paul E. McKenney
2013-04-11 15:53 ` Frederic Weisbecker
2013-04-11 16:10 ` Paul E. McKenney
2013-04-11 16:41 ` Christoph Lameter
2013-04-11 17:04 ` Frederic Weisbecker
2013-04-11 17:11 ` Paul E. McKenney
2013-04-11 17:28 ` Frederic Weisbecker [this message]
2013-04-11 19:17 ` Paul E. McKenney
2013-04-12 15:59 ` Christoph Lameter
2013-04-15 10:27 ` Ingo Molnar
2013-04-15 16:11 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411172803.GC17129@somewhere.redhat.com \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=geoff@infradead.org \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome