From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Julius Werner <jwerner@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [PATCH] usb: xhci-dbg: Display endpoint number and direction in context dump
Date: Mon, 15 Apr 2013 15:24:46 -0700 [thread overview]
Message-ID: <20130415222446.GA13515@xanatos> (raw)
In-Reply-To: <1365466705-12847-1-git-send-email-jwerner@chromium.org>
On Mon, Apr 08, 2013 at 05:18:25PM -0700, Julius Werner wrote:
> diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
> index 5f3a7c7..16a8272 100644
> --- a/drivers/usb/host/xhci-dbg.c
> +++ b/drivers/usb/host/xhci-dbg.c
> @@ -503,11 +503,14 @@ static void xhci_dbg_ep_ctx(struct xhci_hcd *xhci,
> if (last_ep < 31)
> last_ep_ctx = last_ep + 1;
> for (i = 0; i < last_ep_ctx; ++i) {
> + unsigned int epaddr = xhci_get_endpoint_address(i);
> struct xhci_ep_ctx *ep_ctx = xhci_get_ep_ctx(xhci, ctx, i);
> dma_addr_t dma = ctx->dma +
> ((unsigned long)ep_ctx - (unsigned long)ctx->bytes);
>
> - xhci_dbg(xhci, "Endpoint %02d Context:\n", i);
> + xhci_dbg(xhci, "Endpoint %02d %s Context (index %02d):\n",
Sorry, one more nitpick. Can you reword this to be like "Out Endpoint 0x80
Context i" instead of "Endpoint 0x80 OUT Context"? There are input
contexts and output contexts in xHCI, and I want to imply the endpoint
is either IN or OUT, not the context.
Sarah Sharp
next prev parent reply other threads:[~2013-04-15 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 21:03 Julius Werner
2013-04-08 15:41 ` Sarah Sharp
2013-04-09 0:18 ` Julius Werner
2013-04-15 22:24 ` Sarah Sharp [this message]
2013-04-15 22:55 ` Julius Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415222446.GA13515@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®