mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Braun <michael-dev@fami-braun.de>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	projekt-wlan@fem.tu-ilmenau.de,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020
Date: Wed, 17 Apr 2013 12:08:10 +0200	[thread overview]
Message-ID: <20130417100809.GA8855@dynamic.fami-braun.de> (raw)

Hi,

I'm running OpenWRT Kernel 3.8.3 (which already has f66dea709cd9309b2ee9f715697818001fb518de and 5ed338778f917a035f0f0a52327fc4f72e36f7a1 applied) on a P1020WLAN (QorlQ, PPC) device.
Before updating the kernel from 3.3.0, USB host support was working fine. Now I get "fsl-ehci: USB PHY clock invalid" messages in dmesg and the lsusb output is empty, so USB host support is not working. When I apply the following patch, USB host support starts working again, so I guess 3735ba8db8e6ea22ad3ff524328926d8d780a884 is the cause.
Do you have an idea how to fix it more appropriately?

Thanks,
  M. Braun

--- a/drivers/usb/host/ehci-fsl.c       2013-04-15 21:13:52.924403077 +0200
+++ b/drivers/usb/host/ehci-fsl.c       2013-04-15 21:13:57.572410838 +0200
@@ -273,7 +273,6 @@ static int ehci_fsl_setup_phy(struct usb
                 if (!spin_event_timeout(in_be32(non_ehci + FSL_SOC_USB_CTRL) &
                                 PHY_CLK_VALID, FSL_USB_PHY_CLK_TIMEOUT, 0)) {
                         printk(KERN_WARNING "fsl-ehci: USB PHY clock invalid\n");
-                       return -EINVAL;
                 }
         }


             reply	other threads:[~2013-04-17 10:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17 10:08 Michael Braun [this message]
2013-04-17 10:53 ` Liu Shengzhou-B36685
2013-04-18 15:13   ` [Projekt-wlan] " michael-dev
2013-05-19 15:22     ` Michael Braun
2013-05-20  3:37       ` Liu Shengzhou-B36685
2013-05-20  4:43         ` Mehresh Ramneek-B31383
  -- strict thread matches above, loose matches on Subject: below --
2013-04-15 20:16 Michael Braun
2013-04-16 15:35 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130417100809.GA8855@dynamic.fami-braun.de \
    --to=michael-dev@fami-braun.de \
    --cc=Shengzhou.Liu@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=projekt-wlan@fem.tu-ilmenau.de \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome