From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: [for-next][PATCH 4/7] tracing: Get rid of unneeded key calculation in ftrace_hash_move()
Date: Fri, 19 Apr 2013 10:04:06 -0400 [thread overview]
Message-ID: <20130419140556.988391624@goodmis.org> (raw)
In-Reply-To: <20130419140402.730041313@goodmis.org>
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
From: Namhyung Kim <namhyung.kim@lge.com>
It's not used anywhere in the function.
Link: http://lkml.kernel.org/r/1365553093-10180-1-git-send-email-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/ftrace.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 9e31987..3b84fc1 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1320,7 +1320,6 @@ ftrace_hash_move(struct ftrace_ops *ops, int enable,
struct hlist_head *hhd;
struct ftrace_hash *old_hash;
struct ftrace_hash *new_hash;
- unsigned long key;
int size = src->count;
int bits = 0;
int ret;
@@ -1363,10 +1362,6 @@ ftrace_hash_move(struct ftrace_ops *ops, int enable,
for (i = 0; i < size; i++) {
hhd = &src->buckets[i];
hlist_for_each_entry_safe(entry, tp, tn, hhd, hlist) {
- if (bits > 0)
- key = hash_long(entry->ip, bits);
- else
- key = 0;
remove_hash_entry(src, entry);
__add_hash_entry(new_hash, entry);
}
--
1.7.10.4
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-04-19 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 14:04 [for-next][PATCH 0/7] tracing: Various cleanups and small fixes Steven Rostedt
2013-04-19 14:04 ` [for-next][PATCH 1/7] kernel: tracing: Use strlcpy instead of strncpy Steven Rostedt
2013-04-19 14:04 ` [for-next][PATCH 2/7] tracing: Fix off-by-one on allocating stat->pages Steven Rostedt
2013-04-19 14:04 ` [for-next][PATCH 3/7] tracing: Reset ftrace_graph_filter_enabled if count is zero Steven Rostedt
2013-04-19 14:04 ` Steven Rostedt [this message]
2013-04-19 14:04 ` [for-next][PATCH 5/7] tracing: Check return value of tracing_init_dentry() Steven Rostedt
2013-04-19 14:04 ` [for-next][PATCH 6/7] ftrace: Get rid of ftrace_profile_bits Steven Rostedt
2013-04-19 14:04 ` [for-next][PATCH 7/7] tracing: Remove obsolete macro guard _TRACE_PROFILE_INIT Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419140556.988391624@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome