From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
linux-usb <linux-usb@vger.kernel.org>,
usb-storage <usb-storage@lists.one-eyed-alien.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: storage: Convert US_DEBUGP to usb_stor_dbg
Date: Fri, 19 Apr 2013 10:35:03 -0700 [thread overview]
Message-ID: <20130419173503.GA27495@kroah.com> (raw)
In-Reply-To: <1366254055.28609.61.camel@joe-AO722>
On Wed, Apr 17, 2013 at 08:00:55PM -0700, Joe Perches wrote:
> Use a more current logging style with dev_printk
> where possible.
>
> o Convert uses of US_DEBUGP to usb_stor_dbg
> o Add "struct us_data *" to usb_stor_dbg uses
> o usb_stor_dbg now uses struct device */dev_vprint_emit
> o Removed embedded function names
> o Coalesce formats
> o Remove trailing whitespace
> o Remove useless OOM messages
> o Remove useless function entry/exit logging
> o Convert some US_DEBUGP uses to dev_info and dev_dbg
>
> $ size drivers/usb/storage/built-in.o*
> text data bss dec hex filename
> 137787 55520 68584 261891 3ff03 drivers/usb/storage/built-in.o.debug.new
> 140782 55200 68904 264886 40ab6 drivers/usb/storage/built-in.o.debug.old
> 102709 54936 63784 221429 360f5 drivers/usb/storage/built-in.o.no_debug.new
> 101506 54568 63592 219666 35a12 drivers/usb/storage/built-in.o.no_debug.old
>
> Increase in no_debug size is because some previously
> compiled-out US_DEBUGP are now dev_dbg and are compiled
> in and a couple of US_DEBUGP messages are now dev_info.
With your other patch applied, this one seems to not apply to my tree:
checking file drivers/usb/storage/alauda.c
checking file drivers/usb/storage/cypress_atacb.c
checking file drivers/usb/storage/datafab.c
checking file drivers/usb/storage/debug.c
Hunk #1 FAILED at 42.
Hunk #2 succeeded at 150 (offset 1 line).
Hunk #3 succeeded at 172 (offset 1 line).
1 out of 3 hunks FAILED
checking file drivers/usb/storage/debug.h
checking file drivers/usb/storage/ene_ub6250.c
checking file drivers/usb/storage/freecom.c
checking file drivers/usb/storage/initializers.c
checking file drivers/usb/storage/isd200.c
checking file drivers/usb/storage/jumpshot.c
checking file drivers/usb/storage/karma.c
checking file drivers/usb/storage/option_ms.c
checking file drivers/usb/storage/realtek_cr.c
checking file drivers/usb/storage/scsiglue.c
checking file drivers/usb/storage/sddr09.c
checking file drivers/usb/storage/sddr55.c
checking file drivers/usb/storage/shuttle_usbat.c
checking file drivers/usb/storage/sierra_ms.c
checking file drivers/usb/storage/transport.c
checking file drivers/usb/storage/usb.c
next prev parent reply other threads:[~2013-04-19 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 5:44 [PATCH] usb: storage: Add usb_stor_dbg, reduce object size Joe Perches
2013-04-17 14:14 ` Alan Stern
2013-04-17 14:39 ` Joe Perches
2013-04-17 15:06 ` Alan Stern
2013-04-17 17:17 ` Joe Perches
2013-04-17 18:47 ` Alan Stern
2013-04-18 0:18 ` Joe Perches
2013-04-18 14:57 ` Alan Stern
2013-04-18 16:11 ` Joe Perches
2013-04-18 3:00 ` [PATCH] usb: storage: Convert US_DEBUGP to usb_stor_dbg Joe Perches
2013-04-19 17:35 ` Greg Kroah-Hartman [this message]
2013-04-19 17:44 ` Joe Perches
2013-04-19 18:44 ` [PATCH V2] " Joe Perches
2013-04-22 19:35 ` David Rientjes
2013-04-25 22:32 ` Andrew Morton
2013-04-26 8:59 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419173503.GA27495@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®