From: Oleg Nesterov <oleg@redhat.com>
To: Jacob Shin <jacob.shin@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Stephane Eranian <eranian@google.com>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] perf: Add hardware breakpoint address mask
Date: Sun, 21 Apr 2013 19:02:02 +0200 [thread overview]
Message-ID: <20130421170202.GA5358@redhat.com> (raw)
In-Reply-To: <20130420224757.GB6155@jshin-Toonie>
On 04/20, Jacob Shin wrote:
>
> On Sat, Apr 20, 2013 at 06:53:34PM +0200, Oleg Nesterov wrote:
> >
> > And does attr.bp_len "contribute" to the mask?
> >
> > I mean, if bp_len == X86_BREAKPOINT_LEN_8, does this mean that
> > bp_bp_addr_mask and (bp_bp_addr_mask | 7) have the same effect?
>
> Yes it has the same effect.
OK, thanks...
So this is the "natural" extension. Given that currently bp_addr
should be aligned, bp_len could be already bp_mask but I guess it
is too late to change this, so we need another field.
Hmm. Perhaps arch_has_hw_breakpoint_addr_mask(void) should be turned
into arch_validate_hw_breakpoint_addr_mask(bp) which should also
check that (bp_addr & bp_addr_mask) == 0. But I won't insist.
Oleg.
next prev parent reply other threads:[~2013-04-21 17:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 17:21 [PATCH 0/5] perf: Add support for hardware breakpoint address masks Jacob Shin
2013-04-09 17:21 ` [PATCH 1/5] perf: Add hardware breakpoint address mask Jacob Shin
2013-04-20 16:22 ` Oleg Nesterov
2013-04-20 21:46 ` Jacob Shin
2013-04-21 16:43 ` Oleg Nesterov
2013-04-09 17:21 ` [PATCH 2/5] perf, x86: AMD implementation for " Jacob Shin
2013-04-21 17:19 ` Oleg Nesterov
2013-04-22 22:14 ` Jacob Shin
2013-04-09 17:21 ` [PATCH 3/5] perf tools: Add breakpoint address mask to the mem event parser Jacob Shin
2013-04-21 17:10 ` Oleg Nesterov
2013-04-09 17:21 ` [PATCH 4/5] perf tools: Add breakpoint address mask syntax to perf list and documentation Jacob Shin
2013-04-09 17:21 ` [PATCH 5/5] perf tools: Add breakpoint address mask test case to tests/parse-events Jacob Shin
2013-04-15 17:28 ` [PATCH 0/5] perf: Add support for hardware breakpoint address masks Jacob Shin
2013-04-16 9:36 ` Ingo Molnar
2013-04-18 16:38 ` Jacob Shin
2013-04-18 18:57 ` Oleg Nesterov
2013-04-15 23:22 ` Jiri Olsa
2013-04-20 16:53 ` Oleg Nesterov
2013-04-20 22:47 ` [PATCH 1/5] perf: Add hardware breakpoint address mask Jacob Shin
2013-04-21 17:02 ` Oleg Nesterov [this message]
2013-04-22 21:37 ` Jacob Shin
2013-04-22 21:57 ` Jacob Shin
-- strict thread matches above, loose matches on Subject: below --
2012-12-12 16:30 [PATCH 0/5] perf: Add support for hardware breakpoint address masks Jacob Shin
2012-12-12 16:30 ` [PATCH 1/5] perf: Add hardware breakpoint address mask Jacob Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130421170202.GA5358@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jacob.shin@amd.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome