mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
	Randy Dunlap <rdunlap@infradead.org>,
	zhangwei (Jovi) <jovi.zhangwei@huawei.com>
Subject: Re: [PATCH] re-order CONFIG_EXPERT options to fix menuconfig display
Date: Wed, 24 Apr 2013 13:04:43 -0700	[thread overview]
Message-ID: <20130424130443.7f78a5d78a59d7ed9968cc90@linux-foundation.org> (raw)
In-Reply-To: <1366652378-29558-1-git-send-email-vapier@gentoo.org>

On Mon, 22 Apr 2013 13:39:38 -0400 Mike Frysinger <vapier@gentoo.org> wrote:

> The kconfig language requires that dependent options all follow the
> menuconfig symbol in order to be collapsed below it.  Recently some
> hidden options were added below the EXPERT menuconfig, but did not
> depend on EXPERT (because hidden options can't).  This broke the
> display.  So re-order all these options, and while we're here stick
> the PCI quirks under the EXPERT menu (since it isn't sitting with
> any related options).
> 
> Before this commit, we get:
> 	[*] Configure standard kernel features (expert users)  --->
> 	[ ] Sysctl syscall support
> 	[*] Load all symbols for debugging/ksymoops
> 	...
> 	[ ] Embedded system
> 
> Now we get the older (and correct) behavior:
> 	[*] Configure standard kernel features (expert users)  --->
> 	[ ] Embedded system
> And if you go into the expert menu you get the expert options:
> 	[ ] Sysctl syscall support
> 	[*] Load all symbols for debugging/ksymoops
> 	...
> 

This doesn't work as advertised when I graft it on top of
http://ozlabs.org/~akpm/mmots/broken-out/init-kconfig-make-expert-as-config-instead-of-menuconfig.patch
(generally, assuming that next==mainline when we're at -rc8 is a low
percentage move).

I think I'll drop
init-kconfig-make-expert-as-config-instead-of-menuconfig.patch and take
this one, but could everyone please review everything?



  reply	other threads:[~2013-04-24 20:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 17:39 Mike Frysinger
2013-04-24 20:04 ` Andrew Morton [this message]
2013-04-24 21:02   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130424130443.7f78a5d78a59d7ed9968cc90@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®