From: Andrew Morton <akpm@linux-foundation.org>
To: Robin Holt <holt@sgi.com>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Russ Anderson <rja@sgi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH -v6 5/5] Move arch/x86 reboot= handling to generic kernel.
Date: Wed, 24 Apr 2013 15:11:13 -0700 [thread overview]
Message-ID: <20130424151113.0b3bef9e5060eec3e8c9858b@linux-foundation.org> (raw)
In-Reply-To: <1366802333-8890-6-git-send-email-holt@sgi.com>
On Wed, 24 Apr 2013 06:18:53 -0500 Robin Holt <holt@sgi.com> wrote:
> Since arch/x86 has the most extensive reboot= handling and it appears to
> have no effect on the remaining architectures. This patch moves that
> reboot= handling from arch/x86 to the generic kernel.
>
This seems incomplete. These, in arch/x86/kernel/reboot.c
extern int reboot_mode;
extern enum reboot_type reboot_type;
extern int reboot_force;
extern int reboot_default;
should surely be moved into include/linux/reboot.h. But `enum
reboot_type' remains stuck over in
arch/x86/include/asm/emergency-restart.h.
next prev parent reply other threads:[~2013-04-24 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 11:18 [PATCH -v6 0/5] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-04-24 11:18 ` [PATCH -v6 1/5] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-04-24 11:18 ` [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu Robin Holt
2013-04-24 22:17 ` Andrew Morton
2013-04-24 22:19 ` Andrew Morton
2013-04-25 6:57 ` Ingo Molnar
2013-04-25 7:29 ` Andrew Morton
2013-04-25 7:34 ` Ingo Molnar
2013-04-25 15:36 ` Robin Holt
2013-04-24 11:18 ` [PATCH -v6 3/5] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-04-24 11:18 ` [PATCH -v6 4/5] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-04-24 11:18 ` [PATCH -v6 5/5] Move arch/x86 reboot= handling to generic kernel Robin Holt
2013-04-24 22:11 ` Andrew Morton [this message]
2013-04-25 21:23 ` [PATCH -v6 0/5] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424151113.0b3bef9e5060eec3e8c9858b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=holt@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rja@sgi.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®