Re: [PATCH] usb: gadget: multi: Mark {cdc,rndis}_config_register() __init

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Wed, Apr 24, 2013 at 10:05:46AM -0700, Michal Nazarewicz wrote:
> On Wed, Apr 24 2013, Geert Uytterhoeven wrote:
> > If gcc (e.g. 4.1.2) decides not to inline cdc_config_register() and
> > rndis_config_register(), this will cause section mismatch warnings:
> >
> > WARNING: drivers/usb/gadget/g_multi.o(.text+0x32f6): Section mismatch in reference from the function cdc_config_register() to the function .init.text:cdc_do_config()
> > The function cdc_config_register() references
> > the function __init cdc_do_config().
> > This is often because cdc_config_register lacks a __init
> > annotation or the annotation of cdc_do_config is wrong.
> >
> > WARNING: drivers/usb/gadget/g_multi.o(.text+0x3326): Section mismatch in reference from the function rndis_config_register() to the function .init.text:rndis_do_config()
> > The function rndis_config_register() references
> > the function __init rndis_do_config().
> > This is often because rndis_config_register lacks a __init
> > annotation or the annotation of rndis_do_config is wrong.
> >
> > Fortunately they're harmless, as {cdc,rndis}_config_register() are only
> > called from multi_bind(), which is annotated with __ref.
> >
> > Mark {cdc,rndis}_config_register() with the __init annotation to kill the
> > warning.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> 
> With transition to configfs all those __inits and __refs will probably
> go away in the long term though.

that's what I thought. Wouldn't it be better to remove them all already?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]