From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755016Ab3D0OXb (ORCPT ); Sat, 27 Apr 2013 10:23:31 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:42510 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343Ab3D0OXa (ORCPT ); Sat, 27 Apr 2013 10:23:30 -0400 Date: Sat, 27 Apr 2013 07:23:25 -0700 From: Tejun Heo To: Li Zefan Cc: Li Zhong , LKML , Cgroups Subject: Re: [PATCH 2/2] cpuset: fix cpu hotplug vs rebuild_sched_domains() race Message-ID: <20130427142325.GA25051@mtj.dyndns.org> References: <517BA01C.6060806@huawei.com> <517BA02C.8080005@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <517BA02C.8080005@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 27, 2013 at 05:53:48PM +0800, Li Zefan wrote: > rebuild_sched_domains() might pass doms with offlined cpu to > partition_sched_domains(), which results in an oops: > > general protection fault: 0000 [#1] SMP > ... > RIP: 0010:[] [] get_group+0x6e/0x90 > ... > Call Trace: > [] build_sched_domains+0x70c/0xcb0 > [] ? build_sched_domains+0x937/0xcb0 > [] ? kfree+0xe4/0x1b0 > [] ? partition_sched_domains+0xc0/0x470 > [] partition_sched_domains+0x2e5/0x470 > [] ? partition_sched_domains+0xc0/0x470 > [] ? generate_sched_domains+0xc7/0x530 > [] rebuild_sched_domains_locked+0x38/0x70 > [] cpuset_write_resmask+0x1a4/0x500 > [] ? cpuset_mount+0xe0/0xe0 > [] ? cpuset_read_u64+0x100/0x100 > [] ? cgroup_iter_next+0x90/0x90 > [] ? cpuset_css_offline+0x70/0x70 > [] cgroup_file_write+0x133/0x2e0 > [] vfs_write+0xcb/0x130 > [] sys_write+0x64/0xa0 > > Reported-by: Li Zhong > Signed-off-by: Li Zefan Applied 1-2 to cgroup/for-3.10. Thanks. -- tejun