From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de,
jasowang@redhat.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org
Subject: Re: [PATCH net-next] hyperv: Fix a compiler warning in netvsc_send()
Date: Mon, 29 Apr 2013 14:09:32 -0400 (EDT) [thread overview]
Message-ID: <20130429.140932.1477434738582260564.davem@davemloft.net> (raw)
In-Reply-To: <1367000755-2571-1-git-send-email-haiyangz@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 26 Apr 2013 11:25:55 -0700
> Fixed: warning: cast from pointer to integer of different size
>
> The Hyper-V hosts always use 64 bit request id. The guests can have 32 or 64
> bit pointers which equal to the ulong type size. So we cast it to ulong type.
> And, assigning 32bit integer to 64 bit variable works fine.
>
> The VMBus returns the same id in the completion packet. But the value has no
> effect on the host side.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Applied, but:
> - req_id = (u64)packet;
> + req_id = (ulong)packet;
I really do not like these shorthands for fundamental C types, we
generally do not use "ulong", "uint" etc. Please expand them out
explicitly to "unsigned long", "unsigned int", etc.
next prev parent reply other threads:[~2013-04-29 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 18:25 Haiyang Zhang
2013-04-29 18:09 ` David Miller [this message]
2013-04-29 18:30 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429.140932.1477434738582260564.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®