From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759830Ab3D3B5C (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Apr 2013 21:57:02 -0400
Received: from nm12-vm0.access.bullet.mail.sp2.yahoo.com ([98.139.44.126]:26436
	"EHLO nm12-vm0.access.bullet.mail.sp2.yahoo.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758327Ab3D3B5A (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Apr 2013 21:57:00 -0400
X-Yahoo-Newman-Id: 61499.85507.bm@smtp120.sbc.mail.ne1.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: eTN5zGAVM1lkEfNU2yneCcWoRKhSVY9R_4A1STumUsNNPXi
 9mR2K0qzb93Y6UnVLhSmKQWwCCFdtXAFc6zjP08KdgGBHIU5NF33BRAlCQyG
 hZypRa.rq.fg9AyeyLeTjcCp0P3J1GjLjhUN.foJHkZp3BTWkrZrWlNCVWVt
 Q.et0ojPHldzMRrhiK2A2WanlZVNBBOHTiicyAkn3Le2ktczjTVer_An9wAZ
 740FM9ot6SPk7iceOI.es2VfLPSNriQ.A5gzvxtfboKObdtp8wDBgGRQ1Cny
 BdEF3TfOvTBllFgoSxc11cZ1mqPbTzApVVH8p5yrl9pq78LBmGVeesgR7L9e
 AZPBhNFV2eKQlQFsn0r7doOPUKMg.uLB6lq4s1ebBAy0Y64W3dqvU1dgUKa2
 3TbxzVH._6oG3_SkSCi35VI6KAr9.DbLTpjj5s10IO4l0IAl8OM9jCxL6QL_
 KfIaEx.SmvdEC0BCxbVkfHpVdlm9nDCIkVo0-
X-Yahoo-SMTP: zfeO.4KswBCc_PdwTE8HfYDCQ1aNmIcSvQHkDP4uSDBNBSXeKQ--
X-Rocket-Received: from localhost (linux@108.223.40.66 with plain)
        by smtp120.sbc.mail.ne1.yahoo.com with SMTP; 30 Apr 2013 01:57:00 +0000 UTC
Date: Mon, 29 Apr 2013 18:57:01 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, "'Wim Van Sebroeck'" <wim@iguana.be>,
        linux-watchdog@vger.kernel.org
Subject: Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use
 devm_gpio_request_one()
Message-ID: <20130430015700.GA25984@roeck-us.net>
References: <000901ce44bc$38dcfbf0$aa96f3d0$@samsung.com>
 <20130429164425.GJ23799@roeck-us.net>
 <000401ce4545$979de350$c6d9a9f0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000401ce4545$979de350$c6d9a9f0$@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 30, 2013 at 10:54:03AM +0900, Jingoo Han wrote:
> On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote:
> > On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote:
> > > Use devm_gpio_request_one() to make cleanup paths simpler.
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > 
> > This patch also addresses the missing gpio_free in the probe error path
> > (if the call to misc_register() fails).
> 
> When devm_gpio_request_one() is used, there is no need to call
> devm_gpio_free().
> 
> It is because, these resource managed functions such as
> devm_gpio_request_one() allow the driver core to automatically
> clean up any allocation, when probe function fails.
> 
I am well aware of this.

I said this patch _addresses_ a problem, not that it creates one.

Guenter