From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760197Ab3D3B6h (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Apr 2013 21:58:37 -0400
Received: from nm3.access.bullet.mail.sp2.yahoo.com ([98.139.44.130]:37882
	"EHLO nm3.access.bullet.mail.sp2.yahoo.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758378Ab3D3B6f (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Apr 2013 21:58:35 -0400
X-Yahoo-Newman-Id: 238007.6249.bm@smtp110.sbc.mail.gq1.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: xuqfPKEVM1kv_L6kg7QTARFdQF5n9deGWdo.73oeLONUPQy
 qL7j4xwD8KtIYwAMyEIeiu0qyyx3AMd7wsK5utWydGmKcIY7nbMa_VEJzxRo
 fYKMoZoxNAHF1xd50T8ramc0Jelfs1pktJQWayhsivOVovSw1MPWXzqBPTQ_
 MQA3FMroCENKLgxMJsJBXaal87uv1lLXxjMAXaJ7cXi.vGvd5vRCBKMqi1lF
 cWkrtZp8dGM6Q2zjzmcl_KILPm0O7fmOL78P8XRLUi.hyzPSHRx1ucAYTs3J
 j8IvG6xp4agYxatvC8Kb8_KZzJRf5Y_qDb6DESVIyDWl1HKrIPTVJMqkeQaH
 UbwPC8.Hprf_CXcBSaygP6bIiUlBipDKx4U4oiojw_dmYcTZVqhM_5hU1XZk
 LeiqoFTOME1gG2tcTayaficlJoEl6vG.t8dO6Wx8Wap82mZ9NqyhVrySf_mV
 n5s_EKxLHU_QVTcq_MJ_KOnIvlnmZNyjAjVE-
X-Yahoo-SMTP: zfeO.4KswBCc_PdwTE8HfYDCQ1aNmIcSvQHkDP4uSDBNBSXeKQ--
X-Rocket-Received: from localhost (linux@108.223.40.66 with plain)
        by smtp110.sbc.mail.gq1.yahoo.com with SMTP; 29 Apr 2013 18:58:35 -0700 PDT
Date: Mon, 29 Apr 2013 18:58:36 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, "'Wim Van Sebroeck'" <wim@iguana.be>,
        linux-watchdog@vger.kernel.org
Subject: Re: [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
Message-ID: <20130430015836.GB25984@roeck-us.net>
References: <000d01ce44bc$da891380$8f9b3a80$@samsung.com>
 <20130429175507.GC5183@roeck-us.net>
 <000501ce4545$f43495f0$dc9dc1d0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000501ce4545$f43495f0$dc9dc1d0$@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 30, 2013 at 10:56:39AM +0900, Jingoo Han wrote:
> On Tuesday, April 30, 2013 2:55 AM, Guenter Roeck wrote:
> > On Mon, Apr 29, 2013 at 06:35:15PM +0900, Jingoo Han wrote:
> > > Use devm_ioremap() to make cleanup paths simpler.
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > 
> > This patch also addresses the missing call to iounmap() if the call
> > to misc_register fails.
> 
> When devm_ioremap() is used, there is no need to call devm_iounmap().
> 
> It is because, these resource managed functions such as
> devm_ioremap() allow the driver core to automatically
> clean up any allocation, when probe function fails.
> 
Same response as before. Please read my note above. It says clearly
"this patch _addresses_ ...", not "this patch _creates_ ...".

Guenter