From: Alex Williamson <alex.williamson@redhat.com>
To: bhelgaas@google.com
Cc: linux-kernel@vger.kernel.org
Subject: [RFC PATCH 6/8] pci: Split out pci_dev lock/unlock and save/restore
Date: Wed, 01 May 2013 12:43:31 -0600 [thread overview]
Message-ID: <20130501184331.28515.83202.stgit@bling.home> (raw)
In-Reply-To: <20130501181828.28515.68783.stgit@bling.home>
Only cosmetic changes to existing paths.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
drivers/pci/pci.c | 52 +++++++++++++++++++++++++++++++++++-----------------
1 file changed, 35 insertions(+), 17 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index eb50d90..a330ebb 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3292,22 +3292,46 @@ done:
return rc;
}
+static void pci_dev_lock(struct pci_dev *dev)
+{
+ pci_cfg_access_lock(dev);
+ /* block PM suspend, driver probe, etc. */
+ device_lock(&dev->dev);
+}
+
+static void pci_dev_unlock(struct pci_dev *dev)
+{
+ device_unlock(&dev->dev);
+ pci_cfg_access_unlock(dev);
+}
+
+static void pci_dev_save(struct pci_dev *dev)
+{
+ pci_save_state(dev);
+ /*
+ * both INTx and MSI are disabled after the Interrupt Disable bit
+ * is set and the Bus Master bit is cleared.
+ */
+ pci_write_config_word(dev, PCI_COMMAND, PCI_COMMAND_INTX_DISABLE);
+}
+
+static void pci_dev_restore(struct pci_dev *dev)
+{
+ pci_restore_state(dev);
+}
+
static int pci_dev_reset(struct pci_dev *dev, int probe)
{
int rc;
- if (!probe) {
- pci_cfg_access_lock(dev);
- /* block PM suspend, driver probe, etc. */
- device_lock(&dev->dev);
- }
+ if (!probe)
+ pci_dev_lock(dev);
rc = __pci_dev_reset(dev, probe);
- if (!probe) {
- device_unlock(&dev->dev);
- pci_cfg_access_unlock(dev);
- }
+ if (!probe)
+ pci_dev_unlock(dev);
+
return rc;
}
/**
@@ -3398,17 +3422,11 @@ int pci_reset_function(struct pci_dev *dev)
if (rc)
return rc;
- pci_save_state(dev);
-
- /*
- * both INTx and MSI are disabled after the Interrupt Disable bit
- * is set and the Bus Master bit is cleared.
- */
- pci_write_config_word(dev, PCI_COMMAND, PCI_COMMAND_INTX_DISABLE);
+ pci_dev_save(dev);
rc = pci_dev_reset(dev, 0);
- pci_restore_state(dev);
+ pci_dev_restore(dev);
return rc;
}
next prev parent reply other threads:[~2013-05-01 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 18:42 [RFC PATCH 0/8] pci: extended reset capabilities Alex Williamson
2013-05-01 18:43 ` [RFC PATCH 1/8] pci: Create pci_reset_bridge_secondary_bus() Alex Williamson
2013-05-01 18:43 ` [RFC PATCH 2/8] pci: Add hotplug_slot_ops.reset_slot() Alex Williamson
2013-05-01 18:43 ` [RFC PATCH 3/8] pci: Add pci_hp_reset_slot Alex Williamson
2013-05-01 18:43 ` [RFC PATCH 4/8] pci: Implement reset_slot for pciehp Alex Williamson
2013-05-01 18:43 ` [RFC PATCH 5/8] pci: Add reset_slot option to pci_dev_reset Alex Williamson
2013-05-01 18:43 ` Alex Williamson [this message]
2013-05-01 18:43 ` [RFC PATCH 7/8] pci: Add slot and bus reset interfaces Alex Williamson
2013-05-01 18:43 ` [RFC PATCH 8/8] pci: Add reset probe functions Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501184331.28515.83202.stgit@bling.home \
--to=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®