From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759507Ab3EBOfv (ORCPT ); Thu, 2 May 2013 10:35:51 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:59662 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758008Ab3EBOfu (ORCPT ); Thu, 2 May 2013 10:35:50 -0400 Date: Thu, 2 May 2013 09:35:35 -0500 From: "Philip J. Kelleher" To: Jens Axboe Cc: linux-kernel@vger.kernel.org, klebers@linux.vnet.ibm.com, brking@linux.vnet.ibm.com Subject: Re: [PATCH 1/8] rsxx: Adding in debugfs entries. Message-ID: <20130502143535.GB10306@oc6784271780.ibm.com> References: <20130502002317.GA29619@oc6784271780.ibm.com> <20130502080325.GF7800@kernel.dk> <20130502140444.GA10306@oc6784271780.ibm.com> <20130502140753.GS7800@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130502140753.GS7800@kernel.dk> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13050214-3620-0000-0000-0000024CD384 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2013 at 04:07:53PM +0200, Jens Axboe wrote: > On Thu, May 02 2013, Philip J. Kelleher wrote: > > On Thu, May 02, 2013 at 10:03:25AM +0200, Jens Axboe wrote: > > > On Wed, May 01 2013, Philip J. Kelleher wrote: > > > > #define NO_LEGACY 0 > > > > +#define DEBUGFS_NULL NULL > > > > > > > > +static struct dentry *rsxx_debugfs_root = DEBUGFS_NULL; > > > > > > What's the point of DEBUGFS_NULL? > > > > Well, orginally, I had rsxx_debugfs_root initialized to NULL but > > the checkpatch script told me not to initialize directly with 0 > > or NULL. So my solution is the #define macro. > > Well, it's a static variable. The reason checkpatch tells you not to > initialize it to NULL/0 is because the bss is automatically zeroed. > Alright sounds good, I'll remove it. Has the patch series been applied and a new patch with the proper change need to sent or does the entire patch series need to be resubmitted? > -- > Jens Axboe > Thanks, -Philip Kelleher