From: David Miller <davem@davemloft.net>
To: cascardo@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, dm@chelsio.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxgb4: fix error recovery when t4_fw_hello returns a positive value
Date: Fri, 03 May 2013 16:13:40 -0400 (EDT) [thread overview]
Message-ID: <20130503.161340.725942468744060225.davem@davemloft.net> (raw)
In-Reply-To: <1367604664-22368-1-git-send-email-cascardo@linux.vnet.ibm.com>
From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Date: Fri, 3 May 2013 15:11:04 -0300
> Since commit 636f9d371f70f22961fd598fe18380057518ca31 ("cxgb4: Add
> support for T4 configuration file"), t4_fw_hello may return a positive
> value instead of 0 for success. The recovery code tests only for zero
> and fails recovery for any other value.
>
> This fix tests for negative error values and fails only on those cases.
> Error recovery after an error injection works after this change.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Applied.
prev parent reply other threads:[~2013-05-03 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 18:11 Thadeu Lima de Souza Cascardo
2013-05-03 20:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503.161340.725942468744060225.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cascardo@linux.vnet.ibm.com \
--cc=dm@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®