mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: torvalds@linux-foundation.org, bruce.w.allan@intel.com,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [net] e1000e: fix scheduling while atomic bug
Date: Tue, 07 May 2013 07:31:01 -0400 (EDT)	[thread overview]
Message-ID: <20130507.073101.877164997428477669.davem@davemloft.net> (raw)
In-Reply-To: <1367905967-12824-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon,  6 May 2013 22:52:47 -0700

> From: Bruce Allan <bruce.w.allan@intel.com>
> 
> A scheduling while atomic bug was introduced recently (by commit ce43a216
> e1000e: cleanup USLEEP_RANGE checkpatch checks).  Revert the particular
> instance of usleep_range() which causes the bug.
> 
> Reported-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Linus, please apply this directly, thanks:

Acked-by: David S. Miller <davem@davemloft.net>

> ---
>  drivers/net/ethernet/intel/e1000e/e1000.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h
> index 82f1c84..ffbc08f 100644
> --- a/drivers/net/ethernet/intel/e1000e/e1000.h
> +++ b/drivers/net/ethernet/intel/e1000e/e1000.h
> @@ -600,7 +600,7 @@ static inline s32 __ew32_prepare(struct e1000_hw *hw)
>  	s32 i = E1000_ICH_FWSM_PCIM2PCI_COUNT;
>  
>  	while ((er32(FWSM) & E1000_ICH_FWSM_PCIM2PCI) && --i)
> -		usleep_range(50, 100);
> +		udelay(50);
>  
>  	return i;
>  }
> -- 
> 1.7.11.7
> 

      reply	other threads:[~2013-05-07 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07  5:52 Jeff Kirsher
2013-05-07 11:31 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130507.073101.877164997428477669.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bruce.w.allan@intel.com \
    --cc=gospo@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®