From: Mark Brown <broonie@kernel.org>
To: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] regmap: debugfs: Fix start_reg calculation
Date: Tue, 7 May 2013 15:28:51 +0100 [thread overview]
Message-ID: <20130507142851.GU7478@sirena.org.uk> (raw)
In-Reply-To: <1367932297-27926-1-git-send-email-srinivas.kandagatla@st.com>
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Tue, May 07, 2013 at 02:11:37PM +0100, Srinivas KANDAGATLA wrote:
> regmap_debugfs_get_dump_start returns register number, not the actual
> offset into the map. So we use the return value as start to dump the
No, it doesn't - it returns the register it should start reading from.
It's just that the code isn't paying attention to stride and should.
Fix the function, not the callers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-07 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:11 Srinivas KANDAGATLA
2013-05-07 14:28 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507142851.GU7478@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®