mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: a.zummo@towertech.it, yongjun_wei@trendmicro.com.cn,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: rtc-tile: add missing platform_device_unregister() when module exit
Date: Tue, 7 May 2013 16:28:38 -0700	[thread overview]
Message-ID: <20130507162838.81a78e16234ef86e0b332275@linux-foundation.org> (raw)
In-Reply-To: <CAPgLHd86cg11pHka0TRMFkEJV2ETLHwnr3oUo=FpBYnSLk=8sA@mail.gmail.com>

On Sun, 5 May 2013 13:07:00 +0800 Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> We have registered platform device when module init, and
> need unregister it when module exit.
> 
> ...
>
> --- a/drivers/rtc/rtc-tile.c
> +++ b/drivers/rtc/rtc-tile.c
> @@ -146,6 +146,7 @@ exit_driver_unregister:
>   */
>  static void __exit tile_rtc_driver_exit(void)
>  {
> +	platform_device_unregister(tile_rtc_platform_device);
>  	platform_driver_unregister(&tile_rtc_platform_driver);
>  }

We don't need to do a platform_device_put(), as tile_rtc_driver_init()
does?

drivers/rtc/rtc-stmp3xxx.c appears to need the same fix.

  

  reply	other threads:[~2013-05-07 23:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-05  5:07 Wei Yongjun
2013-05-07 23:28 ` Andrew Morton [this message]
2013-05-08  2:46   ` Wei Yongjun
2013-05-08 18:01 ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130507162838.81a78e16234ef86e0b332275@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=weiyj.lk@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®