From: Mark Brown <broonie@kernel.org>
To: Fabio Baltieri <fabio.baltieri@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Ola Lilja <ola.o.lilja@stericsson.com>
Subject: Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support
Date: Wed, 8 May 2013 11:51:24 +0100 [thread overview]
Message-ID: <20130508105124.GA7478@sirena.org.uk> (raw)
In-Reply-To: <1367997261-32048-4-git-send-email-fabio.baltieri@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Wed, May 08, 2013 at 09:14:18AM +0200, Fabio Baltieri wrote:
> Drop pinctrl default/sleep state switching code, as it was breaking the
> capture interface by putting the I2S pins in hi-z mode regardless of its
> usage status, and not giving any real benefit.
>
> Pinctrl default mode configuration is already managed automatically by a
> specific pinctrl hog.
I tend to agree with Lee that this looks like a bad approach - there's a
whole bunch of other code in there which I'd guess is probably equally
broken but only the pinctrl code is being removed. Why not just fix it
(or better yet simplify all this stuff)?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-08 10:51 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 7:14 [PATCH 0/6] Second set of fixes for ux500 ASoC drivers Fabio Baltieri
2013-05-08 7:14 ` [PATCH 1/6] ASoC: ab8500-codec: Add missing ad_to_slot definitions Fabio Baltieri
2013-05-08 7:53 ` Lee Jones
2013-05-08 8:30 ` Fabio Baltieri
2013-05-08 8:47 ` Lee Jones
2013-05-08 10:58 ` Mark Brown
2013-05-08 7:14 ` [PATCH 2/6] ASoC: ux500: Do not clear state if already idle Fabio Baltieri
2013-05-08 8:04 ` Lee Jones
2013-05-08 8:39 ` [PATCH v2 " Fabio Baltieri
2013-05-08 10:34 ` Mark Brown
2013-05-08 11:04 ` Lee Jones
2013-05-08 11:31 ` Mark Brown
2013-05-08 12:03 ` Lee Jones
2013-05-08 12:39 ` Mark Brown
2013-05-08 13:05 ` Lee Jones
2013-05-08 13:48 ` Mark Brown
2013-05-08 14:06 ` Lee Jones
2013-05-09 9:28 ` Mark Brown
2013-05-08 12:04 ` Fabio Baltieri
2013-05-08 12:39 ` Mark Brown
2013-05-08 7:14 ` [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support Fabio Baltieri
2013-05-08 8:07 ` Lee Jones
2013-05-08 8:20 ` Fabio Baltieri
2013-05-08 8:48 ` Lee Jones
2013-05-08 9:00 ` Fabio Baltieri
2013-05-08 10:51 ` Mark Brown [this message]
2013-05-08 11:42 ` Fabio Baltieri
2013-05-08 12:32 ` Mark Brown
2013-05-08 13:10 ` Fabio Baltieri
2013-05-08 13:54 ` Mark Brown
2013-05-08 14:17 ` Fabio Baltieri
2013-05-08 14:27 ` Fabio Baltieri
2013-05-08 14:49 ` Mark Brown
2013-05-08 15:07 ` Lee Jones
2013-05-09 9:34 ` Mark Brown
2013-05-08 14:29 ` Mark Brown
2013-05-08 15:48 ` Fabio Baltieri
2013-05-09 9:41 ` Mark Brown
2013-05-13 10:43 ` Fabio Baltieri
2013-05-17 22:02 ` Linus Walleij
2013-05-08 7:14 ` [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration Fabio Baltieri
2013-05-08 8:18 ` Lee Jones
2013-05-08 11:01 ` Mark Brown
2013-05-08 11:11 ` Lee Jones
2013-05-08 11:32 ` Fabio Baltieri
2013-05-08 12:28 ` Mark Brown
2013-05-08 16:03 ` Fabio Baltieri
2013-05-08 7:14 ` [PATCH 5/6] ASoC: ux500: Swap even/odd AD slot definitions Fabio Baltieri
2013-05-08 8:19 ` Lee Jones
2013-05-08 7:14 ` [PATCH 6/6] ASoC: ux500: Use the first two AD slots for capture Fabio Baltieri
2013-05-08 8:22 ` Lee Jones
2013-05-08 10:56 ` Mark Brown
2013-05-08 11:12 ` Lee Jones
2013-05-08 12:30 ` Mark Brown
2013-05-08 16:08 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508105124.GA7478@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.baltieri@linaro.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ola.o.lilja@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome