From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, Christopher Li <sparse@chrisli.org>
Subject: Re: [patch] err.h: IS_ERR() can accept __user pointers
Date: Wed, 8 May 2013 15:16:22 -0700 [thread overview]
Message-ID: <20130508151622.87bde6d58f96ddca9561541f@linux-foundation.org> (raw)
In-Reply-To: <20130508074221.GA5024@elgon.mountain>
On Wed, 8 May 2013 10:42:22 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Sparse generates a false positive when you pass a __user or __iomem
> pointer to the IS_ERR() functions.
>
> drivers/rtc/rtc-ds1286.c:344:36: sparse: incorrect type in argument 1 (different address spaces)
> drivers/rtc/rtc-ds1286.c:344:36: expected void const *ptr
> drivers/rtc/rtc-ds1286.c:344:36: got unsigned int [noderef] [usertype] <asn:2>*rtcregs
>
> We can silence these by adding a __force here and upgrading to the
> latest git release of Sparse.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This change has no effect when using current Sparse releases.
You often put really important stuff after the ^--- and I always move
it to before the ^--- :)
prev parent reply other threads:[~2013-05-08 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANeU7QnO8MzqT+9BDsXj3=nkKOBKumOwEKGnT=BL_cS0wiPPmw@mail.gmail.com>
2013-05-08 7:42 ` Dan Carpenter
2013-05-08 8:39 ` Christopher Li
2013-05-08 22:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508151622.87bde6d58f96ddca9561541f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®