From: Tony Lindgren <tony@atomide.com>
To: "Vincent Stehlé" <v-stehle@ti.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH] ARM: omap2: gpmc: fix compilation warning
Date: Wed, 8 May 2013 15:26:39 -0700 [thread overview]
Message-ID: <20130508222639.GM32546@atomide.com> (raw)
In-Reply-To: <1367839093-13033-1-git-send-email-v-stehle@ti.com>
* Vincent Stehlé <v-stehle@ti.com> [130506 04:24]:
> Fix the following compilation warning:
>
> arch/arm/mach-omap2/gpmc.c: In function 'gpmc_probe_generic_child':
> arch/arm/mach-omap2/gpmc.c:1477:4: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat]
>
> Signed-off-by: Vincent Stehlé <v-stehle@ti.com>
> Cc: trivial@kernel.org
> ---
> arch/arm/mach-omap2/gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index ed946df..3cd7074 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1474,7 +1474,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
> ret = gpmc_cs_remap(cs, res.start);
> if (ret < 0) {
> dev_err(&pdev->dev, "cannot remap GPMC CS %d to 0x%x\n",
> - cs, res.start);
> + cs, (unsigned)res.start);
> goto err;
> }
You should just change the format for dev_err instead of the casting.
Regards,
Tony
next parent reply other threads:[~2013-05-08 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1367839093-13033-1-git-send-email-v-stehle@ti.com>
2013-05-08 22:26 ` Tony Lindgren [this message]
2013-05-14 17:20 ` [PATCH, v2] " Vincent Stehlé
2013-05-16 17:39 ` Tony Lindgren
2013-05-06 15:38 [PATCH] " Vincent Stehlé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508222639.GM32546@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=v-stehle@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome