mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Trond.Myklebust@netapp.com, torvalds@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-cachefs@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 0/8] Fix assorted FS-Cache issues [ver #2]
Date: Fri, 10 May 2013 20:32:58 +0100	[thread overview]
Message-ID: <20130510193257.3045.77981.stgit@warthog.procyon.org.uk> (raw)



Following this mail is a series of patches to fix a number of FS-Cache issues,
including a number of oopses.  The patches can also be found at:

  http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache

on top of a patch from Tejun Heo to fix a problem in the workqueues.  The
patches are also tagged:

  http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git tags/fscache-20130510

The patches are as follows:

 (1) Provide a system wait_on_atomic_t() and wake_up_atomic_t() (enhancement).

 (2) Don't put spin_lock() in a while-condition as spin_lock() may be wrapped
     with do {} while(0) (cleanup).

 (3) Name i_mutex lock classes rather than using numbers in CacheFiles (cleanup).

 (4) Don't sleep in page release if __GFP_FS is not set (deadlock vs ext4).

 (5) Uninline fscache_object_init() (cleanup).

 (6) Wrap checks on object state (cleanup).

 (7) Simplify the object state machine (need #5 and #6).

 (8) Simplify cookie retention by objects (oops fix, need #1 and #7).

David
---
David Howells (6):
      Add wait_on_atomic_t() and wake_up_atomic_t()
      FS-Cache: Don't sleep in page release if __GFP_FS is not set
      FS-Cache: Uninline fscache_object_init()
      FS-Cache: Wrap checks on object state
      FS-Cache: Fix object state machine to have separate work and wait states
      FS-Cache: Simplify cookie retention for fscache_objects, fixing access problems

J. Bruce Fields (1):
      CacheFiles: name i_mutex lock class explicitly

Sebastian Andrzej Siewior (1):
      fs/fscache: remove spin_lock() from the condition in while()


 fs/cachefiles/interface.c     |   11 
 fs/cachefiles/namei.c         |   10 
 fs/cachefiles/xattr.c         |    6 
 fs/fscache/cache.c            |   34 +
 fs/fscache/cookie.c           |   93 +--
 fs/fscache/fsdef.c            |    1 
 fs/fscache/internal.h         |   11 
 fs/fscache/main.c             |   11 
 fs/fscache/netfs.c            |    1 
 fs/fscache/object-list.c      |  103 ++--
 fs/fscache/object.c           | 1106 +++++++++++++++++++++--------------------
 fs/fscache/operation.c        |   36 +
 fs/fscache/page.c             |   55 +-
 include/linux/fscache-cache.h |  170 +++---
 include/linux/wait.h          |   24 +
 kernel/wait.c                 |   85 +++
 16 files changed, 947 insertions(+), 810 deletions(-)


             reply	other threads:[~2013-05-10 19:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-10 19:32 David Howells [this message]
2013-05-10 19:33 ` [PATCH 1/8] Add wait_on_atomic_t() and wake_up_atomic_t() " David Howells
2013-05-10 19:33 ` [PATCH 2/8] fs/fscache: remove spin_lock() from the condition in while() " David Howells
2013-05-10 19:33 ` [PATCH 3/8] CacheFiles: name i_mutex lock class explicitly " David Howells
2013-05-10 19:33 ` [PATCH 4/8] FS-Cache: Don't sleep in page release if __GFP_FS is not set " David Howells
2013-05-10 19:33 ` [PATCH 5/8] FS-Cache: Uninline fscache_object_init() " David Howells
2013-05-10 19:33 ` [PATCH 6/8] FS-Cache: Wrap checks on object state " David Howells
2013-05-10 19:33 ` [PATCH 7/8] FS-Cache: Fix object state machine to have separate work and wait states " David Howells
2013-05-10 19:34 ` [PATCH 8/8] FS-Cache: Simplify cookie retention for fscache_objects, fixing access problems " David Howells
2013-05-10 20:47 ` [PATCH 1/8] Add wait_on_atomic_t() and wake_up_atomic_t() " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130510193257.3045.77981.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®