From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chao Xie <xiechao.mail@gmail.com>
Cc: Chao Xie <chao.xie@marvell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH V2 0/5] input: pxa27x-keypad: enhancement and device tree support
Date: Tue, 14 May 2013 23:40:39 -0700 [thread overview]
Message-ID: <20130515064039.GA24297@core.coreip.homeip.net> (raw)
In-Reply-To: <CADApbegCt=uGcQxdukq-svi201J+YeAX1M1vs-dKAD_AD9HFPw@mail.gmail.com>
Hi Chao,
On Mon, May 13, 2013 at 04:02:07PM +0800, Chao Xie wrote:
> hi, dmitry
> What is your idea about these patches?
> Do i need add someone else to review them?
>
No, they look good, give me a couple more days but I should apply them.
I am going to fold the first 4 into one patch though.
> On Mon, May 6, 2013 at 11:04 AM, Chao Xie <chao.xie@marvell.com> wrote:
> > The patches include 2 parts
> > 1. use matrix_keypad for matrix keyes support
> > 2. add device tree support for pxa27x-keypad
> >
> > V2->V1:
> > Do not copy the members from pdata. For device tree support,
> > directly allocate the pdata structure.
> >
> > Chao Xie (5):
> > input: pxa27x-keypad: use matrix_keymap for matrix keyes
> > arm: mmp: use matrix_keymap for aspenite
> > arm: mmp: use matrix_keymap for teton_bga
> > input: pxa27x-keypad: remove the unused members at platform data
> > input: pxa27x-keypad: add device tree support
> >
> > .../devicetree/bindings/input/pxa27x-keypad.txt | 60 +++++
> > arch/arm/mach-mmp/aspenite.c | 10 +-
> > arch/arm/mach-mmp/teton_bga.c | 8 +-
> > drivers/input/keyboard/Kconfig | 1 +
> > drivers/input/keyboard/pxa27x_keypad.c | 266 ++++++++++++++++++--
> > include/linux/platform_data/keypad-pxa27x.h | 3 +-
> > 6 files changed, 325 insertions(+), 23 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/input/pxa27x-keypad.txt
> >
> > --
> > 1.7.4.1
> >
--
Dmitry
next prev parent reply other threads:[~2013-05-15 6:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 3:04 Chao Xie
2013-05-06 3:04 ` [PATCH V2 1/5] input: pxa27x-keypad: use matrix_keymap for matrix keyes Chao Xie
2013-05-06 3:04 ` [PATCH V2 2/5] arm: mmp: use matrix_keymap for aspenite Chao Xie
2013-05-06 3:04 ` [PATCH V2 3/5] arm: mmp: use matrix_keymap for teton_bga Chao Xie
2013-05-06 3:04 ` [PATCH V2 4/5] input: pxa27x-keypad: remove the unused members at platform data Chao Xie
2013-06-17 13:10 ` Arnd Bergmann
2013-06-17 17:07 ` Dmitry Torokhov
2013-06-18 1:10 ` Chao Xie
2013-05-06 3:04 ` [PATCH V2 5/5] input: pxa27x-keypad: add device tree support Chao Xie
2013-05-13 8:02 ` [PATCH V2 0/5] input: pxa27x-keypad: enhancement and " Chao Xie
2013-05-15 6:40 ` Dmitry Torokhov [this message]
2013-06-13 2:47 ` Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515064039.GA24297@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chao.xie@marvell.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®