From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759701Ab3EORBs (ORCPT ); Wed, 15 May 2013 13:01:48 -0400 Received: from 19.mo5.mail-out.ovh.net ([46.105.35.78]:55030 "EHLO mo5.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759389Ab3EORBr (ORCPT ); Wed, 15 May 2013 13:01:47 -0400 Date: Wed, 15 May 2013 18:57:26 +0200 From: Jean-Christophe PLAGNIOL-VILLARD To: Eduardo Valentin Cc: Benoit Cousson , Russell King , tony@atomide.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Ovh-Mailout: 178.32.228.5 (mo5.mail-out.ovh.net) Subject: Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices Message-ID: <20130515165726.GK22508@game.jcrosoft.org> References: <1368629928-6723-1-git-send-email-eduardo.valentin@ti.com> <1368629928-6723-4-git-send-email-eduardo.valentin@ti.com> <5193A875.1020000@ti.com> <5193B9AA.7020507@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5193B9AA.7020507@ti.com> X-PGP-Key: http://uboot.jcrosoft.org/plagnioj.asc X-PGP-key-fingerprint: 6309 2BBA 16C8 3A07 1772 CC24 DEFC FFA3 279C CE7C User-Agent: Mutt/1.5.20 (2009-06-14) X-Ovh-Tracer-Id: 13796214509766290302 X-Ovh-Remote: 213.251.161.87 (ns32433.ovh.net) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeifedrkedvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeifedrkedvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12:36 Wed 15 May , Eduardo Valentin wrote: > On 15-05-2013 11:23, Benoit Cousson wrote: > > Hi Eduardo, > > > > On 05/15/2013 04:58 PM, Eduardo Valentin wrote: > >> Include bandgap devices for OMAP4460 devices. > >> > >> Cc: "Benoît Cousson" > >> Cc: Tony Lindgren > >> Cc: Russell King > >> Cc: linux-omap@vger.kernel.org > >> Cc: devicetree-discuss@lists.ozlabs.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: linux-kernel@vger.kernel.org > >> Signed-off-by: Eduardo Valentin > >> --- > >> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi > >> index 2cf227c..e5bfbfe 100644 > >> --- a/arch/arm/boot/dts/omap4460.dtsi > >> +++ b/arch/arm/boot/dts/omap4460.dtsi > >> @@ -29,4 +29,13 @@ > >> <0 55 0x4>; > >> ti,hwmods = "debugss"; > >> }; > >> + > >> + bandgap { > >> + reg = <0x4a002260 0x4 > >> + 0x4a00232C 0x4 > >> + 0x4a002378 0x18>; > >> + compatible = "ti,omap4460-bandgap"; > >> + interrupts = <0 126 4>; /* talert */ > >> + ti,tshut-gpio = <86>; > > > > > > > Why do you need a custom attribute for GPIO? Cannot you use the standard > > one? > > I believe it was by your suggestion :-), during the first attempts to > send this driver. But could not find the thread link :-( sorry. > > > I guess the reasoning to mark it as a ti specific is because it will be > used as IRQ line to treat thermal shutdown (in SW). so use interrup-parent > > > > > Where is the gpio controller phandle? > > > > Usually it looks like this: > > > > gpios = <&gpio1 8 0>; > > > > > > Regards, > > Benoit > > > > > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel