From: Pavel Machek <pavel@ucw.cz>
To: Qiaowei Ren <qiaowei.ren@intel.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Xiaoyan Zhang <xiaoyan.zhang@intel.com>,
Gang Wei <gang.wei@intel.com>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space
Date: Thu, 16 May 2013 18:03:12 +0200 [thread overview]
Message-ID: <20130516160311.GA12299@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1368465884-14779-3-git-send-email-qiaowei.ren@intel.com>
On Tue 2013-05-14 01:24:43, Qiaowei Ren wrote:
> These interfaces are located in /sys/devices/platform/intel_txt/config,
> and including totally 37 files, providing access to Intel TXT
> configuration registers.
This looks like very wrong interface... equivalent of /dev/mem.
> +What: /sys/devices/platform/intel_txt/config/STS_raw
> +Date: May 2013
> +KernelVersion: 3.9
> +Contact: "Qiaowei Ren" <qiaowei.ren@intel.com>
> +Description: TXT.STS is the general status register. This read-only register
> + is used by AC modules and the MLE to get the status of various
> + Intel TXT features.
This is not enough to allow people to understand what this does/should
do, nor does it allow (for example) ARM people to implement something
compatible.
Is there specific reason why "better" interface is impossible?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-05-16 16:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 17:24 [PATCH v2 0/3] Intel TXT driver Qiaowei Ren
2013-05-13 17:24 ` [PATCH v2 1/3] driver: add TXT driver in kernel Qiaowei Ren
2013-05-13 17:31 ` Matthew Garrett
2013-05-14 1:49 ` Ren, Qiaowei
2013-05-13 17:24 ` [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space Qiaowei Ren
2013-05-13 17:35 ` Matthew Garrett
2013-05-14 1:46 ` Ren, Qiaowei
2013-05-16 16:03 ` Pavel Machek [this message]
2013-05-17 8:50 ` Ren, Qiaowei
2013-05-17 18:07 ` Pavel Machek
2022-02-17 11:47 ` [discuss] Improve and merge a driver proposed in 2013: " Dmitrii Okunev
2022-02-17 12:34 ` greg
2022-02-17 12:37 ` Pavel Machek
2022-02-18 18:05 ` Jonathan McDowell
2022-02-22 9:31 ` Pavel Machek
2022-03-09 10:40 ` [RFC PATCH] platform/x86: Add sysfs interface for Intel TXT status Jonathan McDowell
2022-03-09 10:48 ` Greg KH
2022-03-09 10:58 ` Jonathan McDowell
2022-03-09 11:29 ` Greg KH
2022-03-09 10:53 ` Matthew Garrett
2022-03-09 17:55 ` Jonathan McDowell
2022-04-12 14:23 ` [RFC PATCH v2] platform/x86: Add securityfs interface for " Jonathan McDowell
2013-05-13 17:24 ` [PATCH v2 3/3] driver: provide sysfs interfaces to access SMX parameter Qiaowei Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516160311.GA12299@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=gang.wei@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qiaowei.ren@intel.com \
--cc=xiaoyan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®