From: Greg KH <greg@kroah.com>
To: Libo Chen <libo.chen@huawei.com>
Cc: stern@rowland.harvard.edu, grant.likely@linaro.org,
rob.herring@calxeda.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
lizefan@huawei.com, Libo Chen <chenlibo.3@gmail.com>
Subject: Re: [PATCH 3/4] usb: ohci: fix goto wrong tag in err case
Date: Thu, 16 May 2013 17:34:59 -0700 [thread overview]
Message-ID: <20130517003459.GB10235@kroah.com> (raw)
In-Reply-To: <1368075491-38728-4-git-send-email-libo.chen@huawei.com>
On Thu, May 09, 2013 at 12:58:10PM +0800, Libo Chen wrote:
> From: Libo Chen <chenlibo.3@gmail.com>
>
> fix goto wrong tag in usb_hcd_nxp_probe
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/usb/host/ohci-nxp.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index f4988fb..eb294a9 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -234,7 +234,7 @@ static int usb_hcd_nxp_probe(struct platform_device *pdev)
> if (usb_disabled()) {
> dev_err(&pdev->dev, "USB is disabled\n");
> ret = -ENODEV;
> - goto out;
> + goto out1;
Please fix this up to use better error case names so this does not
happen again.
thanks,
greg k-h
next prev parent reply other threads:[~2013-05-17 3:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 4:58 [PATCH 0/4] usb: fix four memleak Libo Chen
2013-05-09 4:58 ` [PATCH 1/4] usb: ehci-s5p: fix memleak when fallback to pdata Libo Chen
2013-05-09 4:58 ` [PATCH 2/4] usb: isp1760-if: fix memleak when platform_get_resource fail Libo Chen
2013-05-09 4:58 ` [PATCH 3/4] usb: ohci: fix goto wrong tag in err case Libo Chen
2013-05-17 0:34 ` Greg KH [this message]
2013-05-09 4:58 ` [PATCH 4/4] usb: tilegx: fix memleak when create hcd fail Libo Chen
2013-05-17 0:34 ` Greg KH
2013-05-17 4:31 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517003459.GB10235@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=chenlibo.3@gmail.com \
--cc=grant.likely@linaro.org \
--cc=libo.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rob.herring@calxeda.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®