From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 3/9] perf top: Get rid of *_threaded() functions
Date: Fri, 17 May 2013 16:28:17 +0200 [thread overview]
Message-ID: <20130517142817.GD3848@krava.brq.redhat.com> (raw)
In-Reply-To: <1368497347-9628-4-git-send-email-namhyung@kernel.org>
On Tue, May 14, 2013 at 11:09:01AM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> Those _threaded() functions are needed to make hist tree handling
> thread-safe, but AFAICS the only thing it does is forcing it to use
> the intermediate 'collapsed' tree. It can be acheived by setting
> sort__need_collapse to 1 in cmd_top() so no need to keep those
> _threaded() variants.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-top.c | 23 +++++++++++++----------
> tools/perf/util/hist.c | 44 ++++++--------------------------------------
> tools/perf/util/hist.h | 4 ----
> 3 files changed, 19 insertions(+), 52 deletions(-)
Acked-by: Jiri Olsa <jolsa@redhat.com>
jirka
next prev parent reply other threads:[~2013-05-17 14:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 2:08 [PATCHSET 0/9] perf tools: Assorted fixes and changes on perf top/report Namhyung Kim
2013-05-14 2:08 ` [PATCH 1/9] perf top: Fix -E option behavior Namhyung Kim
2013-05-17 14:21 ` Jiri Olsa
2013-05-31 11:34 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 2/9] perf top: Fix percent output when no samples collected Namhyung Kim
2013-05-17 14:22 ` Jiri Olsa
2013-05-31 11:35 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 3/9] perf top: Get rid of *_threaded() functions Namhyung Kim
2013-05-17 14:28 ` Jiri Olsa [this message]
2013-05-31 11:37 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 4/9] perf hists: Move locking to its call-sites Namhyung Kim
2013-05-17 14:39 ` Jiri Olsa
2013-05-31 11:38 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 5/9] perf report: Don't be bothered with locking when adding hist entries Namhyung Kim
2013-05-17 14:39 ` Jiri Olsa
2013-05-31 11:39 ` [tip:perf/core] perf report: Don' t bother " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 6/9] perf report: Add --percent-limit option Namhyung Kim
2013-05-31 11:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 7/9] perf top: " Namhyung Kim
2013-05-31 11:42 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 8/9] perf report: Add report.percent-limit config variable Namhyung Kim
2013-05-14 11:05 ` Pekka Enberg
2013-05-15 10:08 ` Namhyung Kim
2013-05-16 7:34 ` Pekka Enberg
2013-05-31 11:43 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-05-14 2:09 ` [PATCH 9/9] perf top: Reuse " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517142817.GD3848@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome