Re: [PATCH 4/5] drivers: net: usb: rtl8150: bug fixing and cleanup

[Francois Romieu <romieu@fr.zoreil.com>]

Petko Manolov <petkan@nucleusys.com> :
[...]
>  static int set_registers(rtl8150_t * dev, u16 indx, u16 size, void *data)
>  {
> -	return usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0),
> -			       RTL8150_REQ_SET_REGS, RTL8150_REQT_WRITE,
> -			       indx, 0, data, size, 500);
> +	int res;
> +
> +	res = usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0),
> +			      RTL8150_REQ_SET_REGS, RTL8150_REQT_WRITE,
> +			      indx, 0, data, size, 500);
> +	if (res < 0)
> +		dev_dbg(&dev->udev->dev, "%s returned %d\n", __func__, res);
> +	return res;

You may move it into a separate patch. It is completely unrelated to the
ctrl_urb changes.

[...]
> +static int async_set_registers(rtl8150_t *dev, u16 indx, u16 size, u16 reg)
>  {

[...]
> +	usb_fill_control_urb(async_urb, dev->udev,
> +	                     usb_sndctrlpipe(dev->udev, 0), (void *) &req->dr,

Useless void * cast.

-- 
Ueimor