From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: torvalds@linux-foundation.org, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/9] liblockdep: Wrap kernel/lockdep.c to allow usage from userspace
Date: Wed, 22 May 2013 11:17:18 +0200 [thread overview]
Message-ID: <20130522091718.GE18810@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1368674141-10796-3-git-send-email-sasha.levin@oracle.com>
On Wed, May 15, 2013 at 11:15:34PM -0400, Sasha Levin wrote:
> --- /dev/null
> +++ b/tools/lib/lockdep/uinclude/linux/lockdep.h
> @@ -0,0 +1,55 @@
> +#ifndef _LIBLOCKDEP_LOCKDEP_H_
> +#define _LIBLOCKDEP_LOCKDEP_H_
> +
> +#include <sys/prctl.h>
> +#include <sys/syscall.h>
> +#include <string.h>
> +#include <limits.h>
> +#include <linux/utsname.h>
> +
> +
> +#define MAX_LOCK_DEPTH 2000UL
> +
> +#include "../../../include/linux/lockdep.h"
> +
> +struct task_struct {
> + u64 curr_chain_key;
> + int lockdep_depth;
> + unsigned int lockdep_recursion;
> + struct held_lock held_locks[MAX_LOCK_DEPTH];
> + gfp_t lockdep_reclaim_gfp;
> + int pid;
> + char comm[17];
> +};
Whee that's a totally awesome MAX_LOCK_DEPTH.. :-)
Should we not also extend the other static allocations, or have you not
yet ran into them? I would suspect that without proper classes we're
bound to run out of class and link storage quite quickly.
next prev parent reply other threads:[~2013-05-22 9:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 3:15 [PATCH v4 0/9] liblockdep: userspace lockdep Sasha Levin
2013-05-16 3:15 ` [PATCH v4 1/9] lockdep: Be nice about building from userspace Sasha Levin
2013-05-16 7:32 ` Pekka Enberg
2013-05-16 3:15 ` [PATCH v4 2/9] liblockdep: Wrap kernel/lockdep.c to allow usage " Sasha Levin
2013-05-22 9:14 ` Peter Zijlstra
2013-05-22 9:17 ` Peter Zijlstra [this message]
2013-05-28 19:30 ` Sasha Levin
2013-05-29 11:11 ` Peter Zijlstra
2013-05-16 3:15 ` [PATCH v4 3/9] liblockdep: Add public headers for pthread_mutex_t implementation Sasha Levin
2013-05-22 9:22 ` Peter Zijlstra
2013-05-28 19:33 ` Sasha Levin
2013-05-29 11:14 ` Peter Zijlstra
2013-05-16 3:15 ` [PATCH v4 4/9] liblockdep: Add pthread_mutex_t test suite Sasha Levin
2013-05-16 3:15 ` [PATCH v4 5/9] liblockdep: Add public headers for pthread_rwlock_t implementation Sasha Levin
2013-05-22 9:23 ` Peter Zijlstra
2013-05-16 3:15 ` [PATCH v4 6/9] liblockdep: Add pthread_rwlock_t test suite Sasha Levin
2013-05-16 3:15 ` [PATCH v4 7/9] liblockdep: Support using LD_PRELOAD Sasha Levin
2013-05-22 9:24 ` Peter Zijlstra
2013-05-28 19:35 ` Sasha Levin
2013-05-29 11:15 ` Peter Zijlstra
2013-05-22 9:27 ` Peter Zijlstra
2013-05-28 19:38 ` Sasha Levin
2013-05-29 11:16 ` Peter Zijlstra
2013-05-16 3:15 ` [PATCH v4 8/9] liblockdep: Add the 'lockdep' user-space utility Sasha Levin
2013-05-22 9:27 ` Peter Zijlstra
2013-05-16 3:15 ` [PATCH v4 9/9] liblockdep: Add a MAINTAINERS entry Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522091718.GE18810@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome