From: Pavel Machek <pavel@ucw.cz>
To: Qiaowei Ren <qiaowei.ren@intel.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
"Signed-off-by: Gang Wei" <gang.wei@intel.com>,
Xiaoyan Zhang <xiaoyan.zhang@intel.com>
Subject: Re: [PATCH v3 2/3] driver: provide sysfs interfaces to access TXT config space
Date: Fri, 24 May 2013 11:58:34 +0200 [thread overview]
Message-ID: <20130524095834.GA14554@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1368587074-12712-3-git-send-email-qiaowei.ren@intel.com>
On Wed 2013-05-15 11:04:33, Qiaowei Ren wrote:
> These interfaces are located in /sys/devices/platform/intel_txt/config,
> and including totally 37 files, providing access to Intel TXT
> configuration registers.
>
> Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com>
> Signed-off-by: Xiaoyan Zhang <xiaoyan.zhang@intel.com>
> Signed-off-by: Gang Wei <gang.wei@intel.com>
You forgot to Cc sysfs maintainer, and proposed interface is not
suitable for reasons explained before.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-05-24 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 3:04 [PATCH v3 0/3] Intel TXT driver Qiaowei Ren
2013-05-15 3:04 ` [PATCH v3 1/3] driver: add TXT driver in kernel Qiaowei Ren
2013-05-15 3:04 ` [PATCH v3 2/3] driver: provide sysfs interfaces to access TXT config space Qiaowei Ren
2013-05-24 9:58 ` Pavel Machek [this message]
2013-05-15 3:04 ` [PATCH v3 3/3] driver: provide sysfs interfaces to access SMX parameter Qiaowei Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524095834.GA14554@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=gang.wei@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qiaowei.ren@intel.com \
--cc=xiaoyan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®