From: Hans Verkuil <hverkuil@xs4all.nl>
To: Libo Chen <libo.chen@huawei.com>
Cc: mchehab@redhat.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, lizefan@huawei.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 22/24] drivers/media/radio/radio-maxiradio: Convert to module_pci_driver
Date: Mon, 27 May 2013 11:32:57 +0200 [thread overview]
Message-ID: <201305271132.57946.hverkuil@xs4all.nl> (raw)
In-Reply-To: <1369621919-12800-1-git-send-email-libo.chen@huawei.com>
On Mon 27 May 2013 04:31:59 Libo Chen wrote:
> use module_pci_driver instead of init/exit, make code clean
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> drivers/media/radio/radio-maxiradio.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/media/radio/radio-maxiradio.c b/drivers/media/radio/radio-maxiradio.c
> index bd4d3a7..1d1c9e1 100644
> --- a/drivers/media/radio/radio-maxiradio.c
> +++ b/drivers/media/radio/radio-maxiradio.c
> @@ -200,15 +200,4 @@ static struct pci_driver maxiradio_driver = {
> .remove = maxiradio_remove,
> };
>
> -static int __init maxiradio_init(void)
> -{
> - return pci_register_driver(&maxiradio_driver);
> -}
> -
> -static void __exit maxiradio_exit(void)
> -{
> - pci_unregister_driver(&maxiradio_driver);
> -}
> -
> -module_init(maxiradio_init);
> -module_exit(maxiradio_exit);
> +module_pci_driver(maxiradio_driver);
>
prev parent reply other threads:[~2013-05-27 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 2:31 Libo Chen
2013-05-27 9:32 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305271132.57946.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=gregkh@linuxfoundation.org \
--cc=libo.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®