From: Lars Poeschel <poeschel@lemonage.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Ryan Mallon <rmallon@gmail.com>,
"mcrapet@gmail.com" <mcrapet@gmail.com>
Subject: Re: [PATCH 00/14] misc/ep93xx_pwm: cleanup driver for conversion to PWM framework
Date: Tue, 28 May 2013 13:42:05 +0200 [thread overview]
Message-ID: <201305281342.05530.poeschel@lemonage.de> (raw)
In-Reply-To: <20130528110011.GC11547@mithrandir>
On Tuesday 28 May 2013 at 13:00:12, Thierry Reding wrote:
> On Mon, May 27, 2013 at 07:12:08PM +0200, Arnd Bergmann wrote:
> > On Monday 27 May 2013, H Hartley Sweeten wrote:
> > > Also, I have a question about the conversion.
> > >
> > > If I strip the sysfs support out of this driver the conversion is
> > > quite simple. But, my use for this driver requires user space
> > > control of the PWM.
> > >
> > > Should I:
> > > 1) convert the driver to the PWM framework and leave the sysfs stuff
> > > in it 2) work out a generic sysfs support for the PWM framework and
> > > then
> > >
> > > convert the driver
> > >
> > > 3) other...
> > >
> > > I've been looking at 2) by doing something like how gpiolib does it.
> > > Do you think that would be acceptable?
> >
> > That would be for Thierry to decide. It does sound better to me than
> > the 1) and I don't have a better idea for 3).
> >
> > I wonder how the arbitration between in-kernel and user-space
> > consumers of the pwm lines would work though.
>
> I've added Lars Poeschel on Cc, who's done some work on a sysfs
> interface for the PWM subsystem already. It's undergone some review
> already[0] and I think he's working on a v2 now.
>
> Thierry
>
> [0]: http://marc.info/?l=linux-kernel&m=136499756101273&w=2
I currently do not have the time to work on a v2 of the pwm sysfs patch but
I will do it as soon as possible - if not someone else will do.
Unfortunately my current involvements in other project will not allow me to
do so for at least next two months.
I received some off-list reactions to my patches from users asking for pwm
sysfs, so there is definitely a need for it!
If you decide to take attempt 2) (which is preferable) I recommend you to
take a look at what I have done and Thierrys review comments. I took the
gpiolib way and the result got rejected for very good reasons.
Regards,
Lars
next prev parent reply other threads:[~2013-05-28 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 23:19 H Hartley Sweeten
2013-05-26 23:32 ` Ryan Mallon
2013-05-27 15:20 ` Arnd Bergmann
2013-05-27 16:27 ` H Hartley Sweeten
2013-05-27 17:12 ` Arnd Bergmann
2013-05-28 11:00 ` Thierry Reding
2013-05-28 11:42 ` Lars Poeschel [this message]
2013-05-29 21:33 ` H Hartley Sweeten
2013-05-30 11:41 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305281342.05530.poeschel@lemonage.de \
--to=poeschel@lemonage.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcrapet@gmail.com \
--cc=rmallon@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®