From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.com
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-am33-list@redhat.com, linux-kernel@vger.kernel.org,
Ken Cox <jkc@redhat.com>
Subject: [PATCH 1/4] MN10300: Fix ret_from_kernel_thread
Date: Tue, 28 May 2013 15:31:22 +0100 [thread overview]
Message-ID: <20130528143122.9479.49715.stgit@warthog.procyon.org.uk> (raw)
ret_from_kernel_thread needs to set A2 to the thread_info pointer before
jumping to syscall_exit.
Without this, we never correctly start userspace.
This was caused by the rejuggling of the fork/exec paths in commit:
ddf23e87a804cbf6fa3818076b33fe023cce09fd
Author: Al Viro <viro@zeniv.linux.org.uk>
Date: Thu Oct 11 17:32:41 2012 -0400
Subject: mn10300: switch to saner kernel_execve() semantics
Reported-by: Ken Cox <jkc@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Ken Cox <jkc@redhat.com>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
---
arch/mn10300/kernel/entry.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mn10300/kernel/entry.S b/arch/mn10300/kernel/entry.S
index 0c631d3..92c3eea 100644
--- a/arch/mn10300/kernel/entry.S
+++ b/arch/mn10300/kernel/entry.S
@@ -60,6 +60,7 @@ ENTRY(ret_from_kernel_thread)
mov (REG_D0,fp),d0
mov (REG_A0,fp),a0
calls (a0)
+ GET_THREAD_INFO a2 # A2 must be set on return from sys_exit()
jmp sys_exit
ENTRY(ret_from_kernel_execve)
next reply other threads:[~2013-05-28 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 14:31 David Howells [this message]
2013-05-28 14:31 ` [PATCH 2/4] MN10300: Enable IRQs more in system call exit work path David Howells
2013-05-28 14:31 ` [PATCH 3/4] MN10300: ASB2305's PCI code needs the definition of XIRQ1 David Howells
2013-05-28 14:31 ` [PATCH 4/4] MN10300: Need pci_iomap() and __pci_ioport_map() defining David Howells
2013-05-28 14:34 [PATCH 1/4] MN10300: Fix ret_from_kernel_thread David Howells
2013-05-28 17:06 ` Linus Torvalds
2013-05-28 18:56 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528143122.9479.49715.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jkc@redhat.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®