From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH] tuntap: forbid changing mq flag for persistent device
Date: Wed, 29 May 2013 00:22:08 -0700 (PDT) [thread overview]
Message-ID: <20130529.002208.1948977466672387293.davem@davemloft.net> (raw)
In-Reply-To: <1369801931-6856-1-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Wed, 29 May 2013 12:32:11 +0800
> We currently allow changing the mq flag (IFF_MULTI_QUEUE) for a persistent
> device. This will result a mismatch between the number the queues in netdev and
> tuntap. This is because we only allocate a 1q netdevice when IFF_MULTI_QUEUE was
> not specified, so when we set the IFF_MULTI_QUEUE and try to attach more queues
> later, netif_set_real_num_tx_queues() may fail which result a single queue
> netdevice with multiple sockets attached.
>
> Solve this by disallowing changing the mq flag for persistent device.
>
> Bug was introduced by commit edfb6a148ce62e5e19354a1dcd9a34e00815c2a1
> (tuntap: reduce memory using of queues).
>
> Reported-by: Sriram Narasimhan <sriram.narasimhan@hp.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied, thanks Jason.
prev parent reply other threads:[~2013-05-29 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 4:32 Jason Wang
2013-05-29 7:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529.002208.1948977466672387293.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®