From: Andrew Morton <akpm@linux-foundation.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Guy Streeter <streeter@redhat.com>,
Eric Paris <eparis@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE
Date: Wed, 29 May 2013 14:59:33 -0700 [thread overview]
Message-ID: <20130529145933.6e02f8379cf20b9c7ef30977@linux-foundation.org> (raw)
In-Reply-To: <20130524173925.GA17177@redhat.com>
On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
> audit_log_start() does wait_for_auditd() in a loop until
> audit_backlog_wait_time passes or audit_skb_queue has a room.
>
> If signal_pending() is true this becomes a busy-wait loop,
> schedule() in TASK_INTERRUPTIBLE won't block.
And that's game over for a uniprocessor non-preempt machine, yes?
> Reported-by: Guy Streeter <streeter@redhat.com>
And what did Guy report? "that looks screwy"? "my machine locked up"?
> @@ -1056,7 +1056,7 @@ static inline void audit_get_stamp(struc
> static void wait_for_auditd(unsigned long sleep_time)
> {
> DECLARE_WAITQUEUE(wait, current);
> - set_current_state(TASK_INTERRUPTIBLE);
> + set_current_state(TASK_UNINTERRUPTIBLE);
> add_wait_queue(&audit_backlog_wait, &wait);
>
> if (audit_backlog_limit &&
next prev parent reply other threads:[~2013-05-29 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 17:39 Oleg Nesterov
2013-05-24 17:41 ` Oleg Nesterov
2013-05-29 21:59 ` Andrew Morton [this message]
2013-05-29 22:08 ` Guy Streeter
2013-05-31 17:10 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529145933.6e02f8379cf20b9c7ef30977@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=streeter@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®