From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758761Ab3E3Vya (ORCPT ); Thu, 30 May 2013 17:54:30 -0400 Received: from ns1.pc-advies.be ([83.149.101.17]:48971 "EHLO spo001.leaseweb.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757599Ab3E3VyX (ORCPT ); Thu, 30 May 2013 17:54:23 -0400 Date: Thu, 30 May 2013 23:54:14 +0200 From: Wim Van Sebroeck To: Guenter Roeck Cc: Don Zickus , "Eric W. Biederman" , linux-watchdog@vger.kernel.org, kexec@lists.infradead.org, LKML , vgoyal@redhat.com, dyoung@redhat.com Subject: Re: [PATCH v3] watchdog: Add hook for kicking in kdump path Message-ID: <20130530215414.GK14258@spo001.leaseweb.com> References: <1366233596-34681-1-git-send-email-dzickus@redhat.com> <87li8gaku0.fsf@xmission.com> <20130418130009.GH79013@redhat.com> <20130418134904.GC2767@roeck-us.net> <20130418135257.GL79013@redhat.com> <20130418145413.GA1980@roeck-us.net> <20130424144226.GI79013@redhat.com> <20130424152142.GA26864@roeck-us.net> <20130527191618.GD14258@spo001.leaseweb.com> <20130528153452.GA21891@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130528153452.GA21891@roeck-us.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, > > Only when you set the .parent field in the watchdog_device data you will get the > > referal in the /sys/class/... tree. In iTCO_wdt.c you have the following code > > that does that: iTCO_wdt_watchdog_dev.parent = dev->dev.parent; > > > > From the watchdog-kernel-api documentation: > > * parent: set this to the parent device (or NULL) before calling > > watchdog_register_device. > > > Hi Wim, > > unfortunately that only works if the driver is instantiated as platform driver, > PCI driver, or similar, where a parent device exists. Some drivers are, however, > instantiated directly from the init function (the BookE driver is an example). > What is the recommended action in this case ? Convert it to a platform driver ? If you don't have a bus related driver (like a pci-driver) then indeed it's a conversion to a platform driver. Kind regards, Wim.