From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: mschiffer@universe-factory.net, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb
Date: Fri, 31 May 2013 01:42:44 -0700 (PDT) [thread overview]
Message-ID: <20130531.014244.1871655049070137342.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpWNAnRTgzjPTPxLU-eqz1nWqD=zyjTgwZaaxbwcpf4KMw@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Fri, 31 May 2013 11:23:11 +0800
> On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer
> <mschiffer@universe-factory.net> wrote:
>> Since some refactoring in 5f5a011, ndisc_send_redirect called
>> ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or
>> in the worst case a panic when the skb_put failed.
>>
>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
>
>
> Good catch!
>
> Reviewed-by: Cong Wang <xiyou.wangcong@gmail.com>
I've queued this up for -stable.
next prev parent reply other threads:[~2013-05-31 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 21:02 Kernel panic in IPv6 ndisc/redirect in kernel 3.9.4 Matthias Schiffer
2013-05-31 1:27 ` [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb Matthias Schiffer
2013-05-31 3:23 ` Cong Wang
2013-05-31 8:42 ` David Miller [this message]
2013-06-07 11:00 ` Matthias Schiffer
2013-06-14 1:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531.014244.1871655049070137342.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®