mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Robert Richter <rric@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org,
	Robert Richter <robert.richter@calxeda.com>
Subject: Re: [PATCH 02/16] perf, persistent: Fix attr size
Date: Fri, 31 May 2013 11:05:59 +0200	[thread overview]
Message-ID: <20130531090559.GC14076@nazgul.tnic> (raw)
In-Reply-To: <1369990056-10310-3-git-send-email-rric@kernel.org>

On Fri, May 31, 2013 at 10:47:22AM +0200, Robert Richter wrote:
> From: Robert Richter <robert.richter@calxeda.com>
> 
> Fixing wrongly determined attribute size.
> 
> Signed-off-by: Robert Richter <robert.richter@calxeda.com>
> ---
>  kernel/events/persistent.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/events/persistent.c b/kernel/events/persistent.c
> index 5335644..9075164 100644
> --- a/kernel/events/persistent.c
> +++ b/kernel/events/persistent.c
> @@ -149,7 +149,7 @@ int perf_add_persistent_event_by_id(int id)
>  	attr->persistent	= 1;
>  	attr->config		= id;
>  	attr->type		= PERF_TYPE_TRACEPOINT;
> -	attr->size		= sizeof(attr);
> +	attr->size		= sizeof(*attr);

Ditto for this one.

  reply	other threads:[~2013-05-31  9:05 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31  8:47 [PATCH 00/16] perf, persistent: Kernel updates for perf tool integration Robert Richter
2013-05-31  8:47 ` [PATCH 01/16] perf, persistent: Fix build error for no-tracepoints configs Robert Richter
2013-05-31  9:05   ` Borislav Petkov
2013-05-31  8:47 ` [PATCH 02/16] perf, persistent: Fix attr size Robert Richter
2013-05-31  9:05   ` Borislav Petkov [this message]
2013-05-31  8:47 ` [PATCH 03/16] perf, persistent: Setting default buffer size to 512k as in perf tools Robert Richter
2013-05-31  9:07   ` Borislav Petkov
2013-05-31  8:47 ` [PATCH 04/16] perf, persistent: Print error code on failure when adding events Robert Richter
2013-05-31  9:10   ` Borislav Petkov
2013-05-31  8:47 ` [PATCH 05/16] perf, persistent: Return resonable error code Robert Richter
2013-05-31  9:11   ` Borislav Petkov
2013-05-31  8:47 ` [PATCH 06/16] perf, persistent: Return -EACCES if mapped buffers must be readonly Robert Richter
2013-05-31  9:12   ` Borislav Petkov
2013-05-31  8:47 ` [PATCH 07/16] perf, persistent: Rework struct pers_event_desc Robert Richter
2013-05-31  8:47 ` [PATCH 08/16] perf, persistent: Remove rb_put() Robert Richter
2013-05-31  8:47 ` [PATCH 09/16] perf, persistent: Introduce get_persistent_event() Robert Richter
2013-05-31  8:47 ` [PATCH 10/16] perf, persistent: Reworking perf_get_persistent_event_fd() Robert Richter
2013-05-31  8:47 ` [PATCH 11/16] perf, persistent: Protect event lists with mutex Robert Richter
2013-05-31  8:47 ` [PATCH 12/16] perf, persistent: Avoid adding identical events Robert Richter
2013-05-31  8:47 ` [PATCH 13/16] perf, persistent: Implementing a persistent pmu Robert Richter
2013-05-31  8:47 ` [PATCH 14/16] perf, persistent: Name each persistent event Robert Richter
2013-05-31  8:47 ` [PATCH 15/16] perf, persistent: Exposing persistent events using sysfs Robert Richter
2013-05-31  8:47 ` [PATCH 16/16] perf, persistent: Allow multiple users for an event Robert Richter
2013-06-03 13:49   ` Jiri Olsa
2013-06-04  8:20     ` Borislav Petkov
2013-06-04  9:19       ` Jiri Olsa
2013-06-04  9:35         ` Borislav Petkov
2013-06-07 13:47           ` Robert Richter
2013-05-31  9:15 ` [PATCH 00/16] perf, persistent: Kernel updates for perf tool integration Borislav Petkov
2013-05-31  9:32   ` Robert Richter
2013-05-31 12:21     ` Borislav Petkov
2013-06-01 16:15       ` Robert Richter
2013-06-02  7:29         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130531090559.GC14076@nazgul.tnic \
    --to=bp@alien8.de \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=robert.richter@calxeda.com \
    --cc=rric@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®