From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] atmel_lcdfb: blank the backlight on remove
Date: Fri, 31 May 2013 17:19:26 +0200 [thread overview]
Message-ID: <20130531151926.GR19468@game.jcrosoft.org> (raw)
In-Reply-To: <1370010519-18691-2-git-send-email-richard.genoud@gmail.com>
On 16:28 Fri 31 May , Richard Genoud wrote:
> When removing atmel_lcdfb module, the backlight is unregistered but not
> blanked. (only for CONFIG_BACKLIGHT_ATMEL_LCDC case).
> This can result in the screen going full white depending on how the PWM
> is wired.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> drivers/video/atmel_lcdfb.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index 6e6491f..e00318f 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -223,8 +223,13 @@ static void init_backlight(struct atmel_lcdfb_info *sinfo)
>
> static void exit_backlight(struct atmel_lcdfb_info *sinfo)
> {
> - if (sinfo->backlight)
> + if (sinfo->backlight) {
if (!sinfo->backlight)
return;
other look ok
if you want ot hte next RC you have 3h to send a v2 before I work off for few
days
Best Regards,
J.
next prev parent reply other threads:[~2013-05-31 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 14:28 [PATCH 1/2] trivial: atmel_lcdfb: add missing error message Richard Genoud
2013-05-31 14:28 ` [PATCH 2/2] atmel_lcdfb: blank the backlight on remove Richard Genoud
2013-05-31 15:19 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-05-31 15:41 ` Richard Genoud
2013-05-31 15:49 ` [PATCHv2 " Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531151926.GR19468@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=richard.genoud@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®