From: Olof Johansson <olof@lixom.net>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, arnd@arndb.de,
kgene.kim@samsung.com, patches@linaro.org
Subject: Re: [PATCH 2/3] ARM: SAMSUNG: Consolidate uncompress subroutine
Date: Fri, 31 May 2013 21:00:46 -0700 [thread overview]
Message-ID: <20130601040046.GB3868@quad.lixom.net> (raw)
In-Reply-To: <1370000944-19786-3-git-send-email-tushar.behera@linaro.org>
On Fri, May 31, 2013 at 05:19:03PM +0530, Tushar Behera wrote:
> For mach-exynos, uart_base is a pointer and the value is calculated
> in the machine folder. For other machines, uart_base is defined as
> a macro in platform directory. For symmetry, the uart_base macro
> definition is removed and the uart_base calculation is moved to
> specific machine folders.
>
> This would help us consolidating uncompress subroutine for s5p64x0.
Sorry, reading these in order and didn't go through all of them.
Same comment here, you can use config_enabled() and return early instead of
adding ifdefs.
-Olof
next prev parent reply other threads:[~2013-06-01 4:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 11:49 [PATCH 0/3] Consolidate uncompress code for Samsung platform Tushar Behera
2013-05-31 11:49 ` [PATCH 1/3] ARM: EXYNOS: uncompress - print debug messages if DEBUG_LL is defined Tushar Behera
2013-06-01 3:59 ` Olof Johansson
2013-06-03 4:57 ` Tushar Behera
2013-05-31 11:49 ` [PATCH 2/3] ARM: SAMSUNG: Consolidate uncompress subroutine Tushar Behera
2013-06-01 4:00 ` Olof Johansson [this message]
2013-05-31 11:49 ` [PATCH 3/3] ARM: S5P64X0: Remove duplicate uncompress code Tushar Behera
2013-06-01 8:41 ` Sylwester Nawrocki
2013-06-03 4:18 ` Tushar Behera
2013-06-03 11:40 ` Tomasz Figa
2013-06-03 11:55 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601040046.GB3868@quad.lixom.net \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®