mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: <balbi@ti.com>, <grant.likely@linaro.org>,
	<rob.herring@calxeda.com>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: lpc32xx_udc: Cocci spatch "memdup.spatch"
Date: Sat, 1 Jun 2013 19:58:54 +0300	[thread overview]
Message-ID: <20130601165854.GA15095@arwen.pp.htv.fi> (raw)
In-Reply-To: <1370079406.29224.1.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

On Sat, Jun 01, 2013 at 11:36:46AM +0200, Thomas Meyer wrote:
> 

-ENOLOG

please add a commit log.

> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> 
> diff -u -p a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -3046,11 +3046,10 @@ static int __init lpc32xx_udc_probe(stru
>  	dma_addr_t dma_handle;
>  	struct device_node *isp1301_node;
>  
> -	udc = kzalloc(sizeof(*udc), GFP_KERNEL);
> +	udc = kmemdup(&controller_template, sizeof(*udc), GFP_KERNEL);
>  	if (!udc)
>  		return -ENOMEM;
>  
> -	memcpy(udc, &controller_template, sizeof(*udc));
>  	for (i = 0; i <= 15; i++)
>  		udc->ep[i].udc = udc;
>  	udc->gadget.ep0 = &udc->ep[0].ep;
> 
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2013-06-01 17:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  9:36 Thomas Meyer
2013-06-01 16:58 ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130601165854.GA15095@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®