From: Felipe Balbi <balbi@ti.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: <balbi@ti.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: Cocci spatch "err_cast.spatch"
Date: Sat, 1 Jun 2013 19:59:22 +0300 [thread overview]
Message-ID: <20130601165922.GC15095@arwen.pp.htv.fi> (raw)
In-Reply-To: <1370081325.29224.42.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
On Sat, Jun 01, 2013 at 12:08:45PM +0200, Thomas Meyer wrote:
>
-ENOLOG
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -1138,7 +1138,7 @@ struct usb_string *usb_gstrings_attach(s
>
> uc = copy_gadget_strings(sp, n_gstrings, n_strings);
> if (IS_ERR(uc))
> - return ERR_PTR(PTR_ERR(uc));
> + return ERR_CAST(uc);
>
> n_gs = get_containers_gs(uc);
> ret = usb_string_ids_tab(cdev, n_gs[0]->strings);
>
> diff -u -p a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -557,7 +557,7 @@ static struct config_group *function_mak
>
> fi = usb_get_function_instance(func_name);
> if (IS_ERR(fi))
> - return ERR_PTR(PTR_ERR(fi));
> + return ERR_CAST(fi);
>
> ret = config_item_set_name(&fi->group.cg_item, name);
> if (ret) {
>
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-01 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 10:08 Thomas Meyer
2013-06-01 16:59 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601165922.GC15095@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®