Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Jun 03, 2013 at 11:30:45AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
> > The gdm72xx driver needs to have either the USB or SDIO implementation
> > enabled to provide useful functionalities, so the driver should depend
> > on either USB or MMC.
> > 
> > Signed-off-by: Ben Chan <benchan@chromium.org>
> > Cc: Sage Ahn <syahn@gctsemi.com>
> > ---
> >  drivers/staging/gdm72xx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
> > index 6905913..8af0dd4 100644
> > --- a/drivers/staging/gdm72xx/Kconfig
> > +++ b/drivers/staging/gdm72xx/Kconfig
> > @@ -4,7 +4,7 @@
> >  
> >  menuconfig WIMAX_GDM72XX
> >  	tristate "GCT GDM72xx WiMAX support"
> > -	depends on NET
> > +	depends on NET && (USB || MMC)
> 
> Really?  Again?
> 
> Are you trying to just get me to ignore your patches?
> 
> If so, you just did a good job, please take a day or two to relax and
> get it right.

Crap, slow mailing list, just decided to spit out the second copy of
this to me, sorry for the rant, I need more coffee.

Or maybe less...

My apologies.

greg k-h