From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287Ab3FDX0o (ORCPT ); Tue, 4 Jun 2013 19:26:44 -0400 Received: from 1wt.eu ([62.212.114.60]:35182 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837Ab3FDWkx (ORCPT ); Tue, 4 Jun 2013 18:40:53 -0400 Message-Id: <20130604172130.802022318@1wt.eu> User-Agent: quilt/0.48-1 Date: Tue, 04 Jun 2013 19:21:42 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Oleg Nesterov , Tetsuo Handa , Rusty Russell , Tejun Heo , David Rientjes , Andrew Morton , Linus Torvalds , Willy Tarreau Subject: [ 012/184] usermodehelper: ____call_usermodehelper() doesnt In-Reply-To: <58df134a4b98edf5b0073e2e1e988fe6@local> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.32-longterm review patch. If anyone has any objections, please let me know. ------------------ need do_exit() From: Oleg Nesterov commit 5b9bd473e3b8a8c6c4ae99be475e6e9b27568555 upstream Minor cleanup. ____call_usermodehelper() can simply return, no need to call do_exit() explicitely. Signed-off-by: Oleg Nesterov Cc: Tetsuo Handa Cc: Rusty Russell Cc: Tejun Heo Cc: David Rientjes Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds [dannf: adjusted to apply to Debian's 2.6.32] Signed-off-by: Willy Tarreau --- kernel/kmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kmod.c b/kernel/kmod.c index 2c2a020..f12d883 100644 --- a/kernel/kmod.c +++ b/kernel/kmod.c @@ -193,7 +193,7 @@ static int ____call_usermodehelper(void *data) /* Exec failed? */ sub_info->retval = retval; - do_exit(0); + return 0; } void call_usermodehelper_freeinfo(struct subprocess_info *info) -- 1.7.12.2.21.g234cd45.dirty